Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: roachtest: surface cloud cluster spec info in artifacts #124653

Closed

Conversation

vidit-bhat
Copy link
Contributor

Backport 1/1 commits from #124243.

/cc @cockroachdb/release


Previously, getting the spec of the VMs on which a roachtest ran was tricky to derive.
This was inadequate because it's often necessary to understand the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing its spec. These files are stored under artifacts/vm_spec.

Epic: none
Fixes: #112707
Release note: None


Release justification: Test only changes

Previously, getting the spec of the VMs on which a roachtest
ran was tricky to derive.
This was inadequate because it's often necessary to understand
the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing
its spec in. These files are stored in the Artifacts directory.

Epic: none
Fixes: cockroachdb#112707
Release note: None
Copy link

blathers-crl bot commented May 24, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 24, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@vidit-bhat vidit-bhat marked this pull request as ready for review May 24, 2024 09:27
@vidit-bhat vidit-bhat requested a review from a team as a code owner May 24, 2024 09:27
@vidit-bhat vidit-bhat requested review from herkolategan and renatolabs and removed request for a team May 24, 2024 09:27
@vidit-bhat
Copy link
Contributor Author

Will follow up with a backport of #124443

@vidit-bhat vidit-bhat requested a review from DarrylWong May 24, 2024 10:55
@srosenberg srosenberg self-requested a review May 24, 2024 15:35
@vidit-bhat vidit-bhat requested a review from srosenberg May 25, 2024 06:37
@vidit-bhat
Copy link
Contributor Author

Had a chat with @renatolabs and decided to limit the backport to 24.1+ since I’d need to backport other PRs to get it to compile.

@vidit-bhat vidit-bhat closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants