roachtest: read from cache when checking for preemption #122018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
renatolabs
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
Did a quick test to make sure preemptions continue to work in this branch: link. |
Previously, the check for VM preemptions after test failure would perform a `Sync` operation, making API calls to GCE in order to find clusters. However, that shouldn't be necessary -- roachtest itself created the cluster, so the cluster data should exist in the cache. This commit also adds more debug information when the cluster cannot be found (a list of existing clusters). While this shouldn't happen in practice in regular runs, we have seen it fail in the past. Fixes: cockroachdb#121488 Release note: None
renatolabs
force-pushed
the
rc/roachtest-cluster-not-found-debug-info
branch
from
bd26a48 to
2743138
Compare
srosenberg
approved these changes
Apr 9, 2024
|
TFTR! bors r=srosenberg |
|
Build failed: |
|
bors retry |
|
blathers backport 24.1 |
|
blathers backport 23.2 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 2743138 to blathers/backport-release-23.2-122018: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check for VM preemptions after test failure would perform a
Syncoperation, making API calls to GCE in order to find clusters. However, that shouldn't be necessary -- roachtest itself created the cluster, so the cluster data should exist in the cache.This commit also adds more debug information when the cluster cannot be found (a list of existing clusters). While this shouldn't happen in practice in regular runs, we have seen it fail in the past.
Fixes: #121488
Release note: None