multiregionccl: reenable regional_by_table test #104877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs: cockroachdb#98020 I wasn't able to repro the error mentioned in cockroachdb#98020 for all the 3 tests by stressing 2k runs. Assuming that something has been changed and we're fine now. But just enabling one test at a time just in case it would fail in CI for some reason. Release note: None
|
This change is |
rafiss
approved these changes
Jun 14, 2023
|
TFTR! |
|
Build succeeded: |
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this pull request
Jun 22, 2023
we unskipped `regional_by_table` test in cockroachdb#104877 and haven't seen any error for 7 days now. But still unskipping one test at a time. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
105337: cli/start: soften some deprecation words r=mdlinville a=knz Fixes CRDB-28971 Epic: CRDB-28893 Before: ``` This feature will be removed in the next version of CockroachDB. ``` After: ``` This feature will be removed in a later version of CockroachDB. ``` Release note: None 105346: sql: enable secondary_region test r=chengxiong-ruan a=chengxiong-ruan we unskipped `regional_by_table` test in #104877 and haven't seen any error for 7 days now. But still unskipping one test at a time. Informs: #98020 Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]>
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this pull request
Jun 26, 2023
Followup of cockroachdb#104877 and cockroachdb#105346, this is the last test in the serie. Informs: cockroachdb#98020 Release note: None
|
blathers backport 23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #98020
I wasn't able to repro the error mentioned in #98020 for all the 3 tests by stressing 2k runs. Assuming that something has been changed and we're fine now. But just enabling one test at a time just in case it would fail in CI for some reason.
Release note: None