Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/start: soften some deprecation words #105337

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 22, 2023

Fixes CRDB-28971
Epic: CRDB-28893

Before:

This feature will be removed in the next version of CockroachDB.

After:

This feature will be removed in a later version of CockroachDB.

Release note: None

Before:
```
This feature will be removed in the next version of CockroachDB.
```

After:
```
This feature will be removed in a later version of CockroachDB.
```

Release note: None
@knz knz requested a review from mdlinville June 22, 2023 12:39
@knz knz requested review from a team as code owners June 22, 2023 12:39
@blathers-crl
Copy link

blathers-crl bot commented Jun 22, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jun 22, 2023
@knz knz requested a review from aliher1911 June 22, 2023 15:33
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knz
Copy link
Contributor Author

knz commented Jun 22, 2023

TFYR!

bors r=mdlinville

@craig
Copy link
Contributor

craig bot commented Jun 22, 2023

Build succeeded:

@craig craig bot merged commit 588959f into cockroachdb:master Jun 22, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 22, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-105337 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/105360/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@knz knz deleted the 20230622-soften-deprecation branch June 22, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants