sql: enable secondary_region test #105346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we unskipped `regional_by_table` test in cockroachdb#104877 and haven't seen any error for 7 days now. But still unskipping one test at a time. Release note: None
|
This change is |
|
TFTR! |
|
Build succeeded: |
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this pull request
Jun 26, 2023
Followup of cockroachdb#104877 and cockroachdb#105346, this is the last test in the serie. Informs: cockroachdb#98020 Release note: None
|
I believe this is still flaky. Saw this failure on a PR with unrelated changes: |
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this pull request
Jun 28, 2023
Unfortunately, it's still flaky: cockroachdb#105346 (comment) Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
105758: sql: skip multiregional tests again r=chengxiong-ruan a=chengxiong-ruan Unfortunately, it's still flaky: #105346 (comment) Informs: #98020 Release note: None 105893: persistedsqlstats: skip TestSQLStatsPersistedLimitReached r=zachlite a=zachlite Flakes in Bazel essential CI. Reverts #105770 Informs #105846, #97488 Epic: none Release note: None Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: zachlite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we unskipped
regional_by_tabletest in #104877 and haven't seen any error for 7 days now. But still unskipping one test at a time.Informs: #98020
Release note: None