Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench/rttanalysis: TestBenchmarkExpectation failed #73884

Closed
cockroach-teamcity opened this issue Dec 16, 2021 · 0 comments · Fixed by #74111
Closed

bench/rttanalysis: TestBenchmarkExpectation failed #73884

cockroach-teamcity opened this issue Dec 16, 2021 · 0 comments · Fixed by #74111
Assignees
@ajwerner
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

bench/rttanalysis.TestBenchmarkExpectation failed with artifacts on master @ 9df83c67afab064b5177e2663ed42b8fbeef8ba3:

--- FAIL: TestBenchmarkExpectation (25.62s)
=== RUN   TestBenchmarkExpectation/AlterTableDropColumn/alter_table_drop_1_column
=== CONT  TestBenchmarkExpectation/AlterTableDropColumn/alter_table_drop_1_column
    rtt_analysis_bench.go:152: AlterTableDropColumn/alter_table_drop_1_column: got 22, expected 21
    rtt_analysis_bench.go:158: wrote jaeger trace to /go/src/github.com/cockroachdb/cockroach/artifacts/logTestBenchmarkExpectation420642434/AlterTableDropColumn_alter_table_drop_1_column.jaeger.json
        --- FAIL: TestBenchmarkExpectation/AlterTableDropColumn/alter_table_drop_1_column (9.26s)
=== RUN   TestBenchmarkExpectation/AlterTableDropColumn
    --- FAIL: TestBenchmarkExpectation/AlterTableDropColumn (18.55s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-json

Same failure on other branches

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Dec 16, 2021
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Dec 16, 2021
@rafiss rafiss mentioned this issue Dec 16, 2021
Merged
@ajwerner ajwerner self-assigned this Dec 16, 2021
ajwerner added a commit to ajwerner/cockroach that referenced this issue Dec 21, 2021
@ajwerner
bench/rttanalysis: allow roundtrips to be off by 1
f8283b3 
If we don't have a range, let the currently estimate be wrong by 1.
We mostly care about the ballpark and the growth rate. I'm sick of
these flakes.

Fixes cockroachdb#73884.

Release note: None
@ajwerner ajwerner mentioned this issue Dec 21, 2021
Merged
craig bot pushed a commit that referenced this issue Dec 21, 2021
@knz @RaduBerinde
@cucaroach @mgartner @rickystewart @ajwerner
Merge #72992 #73937 #73978 #74102 #74110 #74111 #74152
779f08b 
72992: util/log: fix redactability of logging tags r=abarganier a=knz

Fixes #72905.

Some time in the v21.2 cycle, the log entry preparation logic was
refactored and a mistake was introduced: the logging tags were not any
more subject to the redaction logic. The result was that redaction
markers were missing in log tag values, and if a value had contained
unbalanced redaction markers in a value string (say, as part of a SQL
table key), it would have caused log file corruption and possibly a
confidential data leak.

This patch fixes that, by preparing the logging tags in the same way
as the main message for each entry.

Release note (cli change): A bug affecting the redactability of
logging tags in output log entries has been fixed. This bug had
been introduced in the v21.2 release.

73937: setting: introduce setting classes r=RaduBerinde a=RaduBerinde

This commit introduces the three setting classes in the RFC (#73349):
`SystemOnly`, `TenantReadOnly`, and `TenantWritable`. The `SystemOnly`
class replaces the existing `WithSystemOnly()`.

In this change we don't yet implement the advertised semantics. We
mechanically use `TenantWritable` for all settings except those that
were using `WithSystemOnly()` which use `SystemOnly`; this should not
change any existing behavior. The classes will be revisited in a
separate change, after we implement the semantics.

Release note: None

73978: opt: fix like escape processing for span constraints r=cucaroach a=cucaroach

Fixes: #44123

Previously no attempt was made to properly handle escape ('\\') sequence
in like patterns being turned into constraints. Refactor code used to
process like at runtime to generate a regexp and use that to properly
handle index constraint generation.

Release note (sql change): Escape character processing was missing from
constraint span generation which resulted in incorrect results when
doing escaped like lookups.

74102: sql: do not fetch virtual columns during backfill r=mgartner a=mgartner

Fixes #73372

Release note (bug fix): A bug has been fixed that caused internal errors
when altering the primary key of a table. The bug was only present if
the table had a partial index with a predicate that referenced a virtual
computed column. This bug was present since virtual computed columns
were added in version 21.1.0.

74110: bazel: require setting `cockroach_cross=y` to opt into cross toolchains r=irfansharif a=rickystewart

With `--incompatible_enable_cc_toolchain_resolution` set in #73819, now
Bazel selects the appropriate toolchain for you. Bazel was selecting the
`cross_linux_toolchain` when building for the host platform on Linux,
resulting in link errors when trying to compile `stress` under `race`.
We update the toolchains to instead require opting into the cross
toolchains by defining `cockroach_cross=y`.

Closes #73997.

Release note: None

74111: bench/rttanalysis: allow roundtrips to be off by 1 r=ajwerner a=ajwerner

If we don't have a range, let the currently estimate be wrong by 1.
We mostly care about the ballpark and the growth rate. I'm sick of
these flakes.

Fixes #73884.

Release note: None

74152: ci: don't delete `test.json.txt` after processing r=tbg a=rickystewart

We've seen some issues where Bazel jobs are failing in `github-post`
(#73841, #74013) with the following output:

    found outstanding output. Considering last test failed:

It's hard to say what the problem is because these scripts haven't kept
the `test.json.txt` in `artifacts`. Here I remove the logic to clean up
the file so we can RC further instances of the problem.

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in #74111 Dec 21, 2021
@craig craig bot closed this as completed in 0750472 Dec 21, 2021
gustasva pushed a commit to gustasva/cockroach that referenced this issue Jan 4, 2022
@ajwerner
bench/rttanalysis: allow roundtrips to be off by 1
0df661b 
If we don't have a range, let the currently estimate be wrong by 1.
We mostly care about the ballpark and the growth rate. I'm sick of
these flakes.

Fixes cockroachdb#73884.

Release note: None
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bench/rttanalysis: allow roundtrips to be off by 1 ajwerner/cockroach
2 participants
@ajwerner @cockroach-teamcity