Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: do not fetch virtual columns during backfill #74102

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

mgartner
Copy link
Collaborator

Fixes #73372

Release note (bug fix): A bug has been fixed that caused internal errors
when altering the primary key of a table. The bug was only present if
the table had a partial index with a predicate that referenced a virtual
computed column. This bug was present since virtual computed columns
were added in version 21.1.0.

@mgartner mgartner requested a review from ajwerner December 20, 2021 21:37
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Fixes cockroachdb#73372

Release note (bug fix): A bug has been fixed that caused internal errors
when altering the primary key of a table. The bug was only present if
the table had a partial index with a predicate that referenced a virtual
computed column. This bug was present since virtual computed columns
were added in version 21.1.0.
@mgartner mgartner force-pushed the 73372-fix-virtual-backfill branch from 0f9cee9 to 0d4e0d9 Compare December 20, 2021 22:58
@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 21, 2021

Build succeeded:

@craig craig bot merged commit 779f08b into cockroachdb:master Dec 21, 2021
@mgartner mgartner deleted the 73372-fix-virtual-backfill branch December 21, 2021 19:41
@rafiss
Copy link
Collaborator

rafiss commented Jan 19, 2022

blathers backport 21.1 21.2

@blathers-crl
Copy link

blathers-crl bot commented Jan 19, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 0d4e0d9 to blathers/backport-release-21.1-74102: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@mgartner
Copy link
Collaborator Author

Yikes, I lost track of this. Thanks for finding it! I'll put up a backport for 21.1 momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest/sqlsmith: non-nullable column with no value during backfill
4 participants