Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't delete test.json.txt after processing #74152

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

rickystewart
Copy link
Collaborator

We've seen some issues where Bazel jobs are failing in github-post
(#73841, #74013) with the following output:

found outstanding output. Considering last test failed:

It's hard to say what the problem is because these scripts haven't kept
the test.json.txt in artifacts. Here I remove the logic to clean up
the file so we can RC further instances of the problem.

Release note: None

We've seen some issues where Bazel jobs are failing in `github-post`
(cockroachdb#73841, cockroachdb#74013) with the following output:

    found outstanding output. Considering last test failed:

It's hard to say what the problem is because these scripts haven't kept
the `test.json.txt` in `artifacts`. Here I remove the logic to clean up
the file so we can RC further instances of the problem.

Release note: None
@rickystewart rickystewart requested a review from tbg December 21, 2021 15:56
@rickystewart rickystewart requested a review from a team as a code owner December 21, 2021 15:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 🧑‍🔬 🐶

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rickystewart
Copy link
Collaborator Author

TFTR!

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Dec 21, 2021

Build succeeded:

@craig craig bot merged commit 779f08b into cockroachdb:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants