Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test: TestLogic_mixed_version_sequence_per_node_cache failed #119978

Closed
cockroach-teamcity opened this issue Mar 5, 2024 · 6 comments · Fixed by #119999
Closed

pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test: TestLogic_mixed_version_sequence_per_node_cache failed #119978

cockroach-teamcity opened this issue Mar 5, 2024 · 6 comments · Fixed by #119999
Assignees
@jasminejsun
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 5, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test.TestLogic_mixed_version_sequence_per_node_cache failed with artifacts on master @ 583bfa4868b1aecedff86102ae55cde3b1748fd6:

=== RUN   TestLogic_mixed_version_sequence_per_node_cache
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/035e488ec2993725f1d7ba8eb7150687/logTestLogic_mixed_version_sequence_per_node_cache2381433756
    test_log_scope.go:81: use -show-logs to present logs inline
[23:30:08] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache: 6 statements
[23:30:40] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache: 10 statements
    logic.go:2952: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache:63: SELECT crdb_internal.is_at_least_version('23.2-18')
        expected:
            true
            
        but found (query options: "retry") :
            false
            
[23:31:26] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache: 12 statements
[23:31:26] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache with config cockroach-go-testserver-23.2: 12 tests, 1 failures
    logic.go:4130: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache:68: error while processing
    logic.go:4130: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8579/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test_/cockroach-go-testserver-23_2_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache:68: too many errors encountered, skipping the rest of the input
cockroach logs captured in: /artifacts/tmp/_tmp/035e488ec2993725f1d7ba8eb7150687/cockroach-logs3040208645
    panic.go:626: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/035e488ec2993725f1d7ba8eb7150687/logTestLogic_mixed_version_sequence_per_node_cache2381433756
--- FAIL: TestLogic_mixed_version_sequence_per_node_cache (91.79s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-36421
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Mar 5, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Mar 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Mar 5, 2024
@DrewKimball
Copy link
Collaborator

This is a new test running into #112621. We'll have to skip any logic that runs after the upgrade completes until that issue is fixed.

@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 6, 2024
@mgartner mgartner removed this from SQL Queries Mar 6, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Mar 6, 2024
@mgartner mgartner removed the T-sql-queries SQL Queries Team label Mar 6, 2024
@mgartner mgartner removed this from SQL Queries Mar 6, 2024
@mgartner
Copy link
Collaborator

mgartner commented Mar 6, 2024

cc @jasminejsun can you skip this test until #112621 is addressed (unless fixing that is as quick as skipping)?

@jasminejsun
Copy link
Contributor

skip

yes, we can skip it for now!

@jasminejsun jasminejsun self-assigned this Mar 6, 2024
jasminejsun added a commit to jasminejsun/cockroach that referenced this issue Mar 6, 2024
@jasminejsun
sql: skip mixed version test for node-level sequence caching
741f91a 
We should skip any logic that runs after the upgrade completes until issue cockroachdb#112621  is fixed.

Epic: none
Fixes: cockroachdb#119978

Release note: None
@jasminejsun jasminejsun mentioned this issue Mar 6, 2024
Merged
@rafiss
Copy link
Collaborator

rafiss commented Mar 6, 2024

@mgartner @jasminejsun: there is a way to make sure the upgrade completes (which I forgot about last time this issue came up).

Running set cluster setting version = crdb_internal.node_executable_version(); will block until the upgrades are complete.

@exalate-issue-sync exalate-issue-sync bot added P-1 Issues/test failures with a fix SLA of 1 month and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 6, 2024
jasminejsun added a commit to jasminejsun/cockroach that referenced this issue Mar 6, 2024
@jasminejsun
sql: skip mixed version test for node-level sequence caching
5e578a7 
We should skip any logic that runs after the upgrade completes until issue cockroachdb#112621  is fixed.

Epic: none
Fixes: cockroachdb#119978

Release note: None
craig bot pushed a commit that referenced this issue Mar 6, 2024
@annrpom @xinhaoz
@dhartunian @jasminejsun @rafiss
Merge #118995 #119752 #119971 #119977 #119999 #120005
82eb30e 
118995: schemachanger: support CREATE SCHEMA ... AUTHORIZATION r=fqazi a=annrpom

This patch enables support for `CREATE SCHEMA ... AUTHORIZATION` in the declarative schema changer

Fixes: #115369
Epic: [CRDB-31331](https://cockroachlabs.atlassian.net/browse/CRDB-31331)

Release note: None

119752: sqlstats: dont block flush due to sql activity job r=xinhaoz a=xinhaoz

The sql stats flush worker signals the sql activity update job on flush completion via an unbuffered channel. It currently blocks on sending that signal so if that job is stuck updating stats for some reason this also makes the flush stuck. This commit ensures that the flush worker can continue normally even if the sql activity update job is not ready to receive its next signal. This ensures that the coordinator node for the sql stats activity job can continue to collect sql stats normally.

Epic: none
Fixes: #119751

119971: sqlstats: skip TestTransactionServiceLatencyOnExtendedProtocol r=xinhaoz a=xinhaoz

Skip this test until we fix the data race caused by the testing knob functions.

Epic: none

Release note: None

119977: sqlstats: add retries to stats test on locked table r=xinhaoz a=dhartunian

Previously, the `TestSQLStatsReadLimitSizeOnLockedTable` test would fail very occasionally due to a rare scenario. When stats are written, they contain a column that's a hashed shard index. It's expected that statements are uniformly distributed across this shard, but that's not guaranteed. Later in the test we check a random shard to make sure its stats count exceeds a minimum of 1 (because we place a total lower bound of 8 in the cluster setting, which is then divided by 8 to derive the per-shard limit). This case will occasionally fail if the random shard that's picked happens to only contain a single statement within.

This change modifies the loop at the end of the test to expect a `false` value and make sure to get at least a single `true` result after 3 iterations, instead of requiring 3 `true` results every single time. The requirement that the queries run despite contention will still stand since we'll return an error in that case.

Resolves: #119067
Epic: None

Release note: None

119999: sql: fix mixed version test for node-level sequence caching r=jasminejsun a=jasminejsun

Fix mixed version test for node-level sequence caching by making it wait for upgrade to complete.

Epic: none
Fixes: #119978

Release note: None

120005: logictest: update cache size for on-disk logictest configs r=rafiss a=rafiss

The default cache size is 128MB. This can result in disk-related slowdowns for normal operations. Now we configure a larger cache so that we avoid disk access.

fixes #119897
Release note: None

Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Jasmine Sun <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
@craig craig bot closed this as completed in d6981c4 Mar 6, 2024
@mgartner
Copy link
Collaborator

mgartner commented Mar 6, 2024

Thanks for the tip! I think I could use that here:

cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_udf_execute_privileges

Line 77 in 29e1641

# SELECT crdb_internal.is_at_least_version('23.2')

@rafiss
Copy link
Collaborator

rafiss commented Mar 6, 2024

i've created #120003 to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasminejsun jasminejsun

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Status: Done
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

sql: fix mixed version test for node-level sequence caching jasminejsun/cockroach
5 participants
@mgartner @rafiss @cockroach-teamcity @DrewKimball @jasminejsun