-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemachanger: support CREATE SCHEMA ... AUTHORIZATION #118995
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
b0f66a4
to
bf10ce2
Compare
Is there a reason as to why CREATE SCHEMA isn't enabled? It's version gated by 23.2 |
^ from the above comment:
|
Apologies for the hoarding on this one - prioritized on-call duties, but finally got to testing last week to make sure I'm not missing anything obvious. RFAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @annrpom, @herkolategan, and @srosenberg)
pkg/sql/schemachanger/scbuild/internal/scbuildstmt/create_schema.go
line 74 at r1 (raw file):
owner := b.CurrentUser() if !n.AuthRole.Undefined() { authRole, err := decodeusername.FromRoleSpec(
It would be nice to get an end to end test to cover this.
As discussed in our team weekly, we have an issue out to do exactly this (enable CREATE SCHEMA). I'll leave out commit 2 since it relies on said issue |
This patch enables support for `CREATE SCHEMA ... AUTHORIZATION` in the declarative schemachanger Fixes: cockroachdb#115369 Epic: CRDB-31331 Release note: None
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @annrpom, @herkolategan, and @srosenberg)
TFTR! ('-')7 bors r=fqazi |
Build succeeded: |
This patch enables support for
CREATE SCHEMA ... AUTHORIZATION
in the declarative schema changerFixes: #115369
Epic: CRDB-31331
Release note: None