sql: fix mixed version test for node-level sequence caching #119999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jasminejsun
force-pushed
the
fix_mixed_version_test_node_sequence_cache
branch
from
741f91a to
5e578a7
Compare
fqazi
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jasminejsun and @mgartner)
-- commits line 4 at r2:
The commit message is off, since the change below now makes it wait.
jasminejsun
force-pushed
the
fix_mixed_version_test_node_sequence_cache
branch
from
5e578a7 to
6e65d00
Compare
Fix mixed version test for node-level sequence caching by making it wait for upgrade to complete. Epic: none Fixes: cockroachdb#119978 Release note: None
jasminejsun
force-pushed
the
fix_mixed_version_test_node_sequence_cache
branch
from
6e65d00 to
d6981c4
Compare
jasminejsun
changed the title
rafiss
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
thanks for the fix!
Reviewable status:
fqazi
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mixed version test for node-level sequence caching by making it wait for upgrade to complete.
Epic: none
Fixes: #119978
Release note: None