-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SiPhase2OuterTrackerLorentzAngle #31095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rentzAngleRcd,SiPhase2OuterTrackerLorentzAngleSimRcd
… Phase-2 Tracker Digitizer
… the Phase2 Tracker CPE estimation
+1 |
+1 |
+1
|
+1 |
+upgrade |
+1 |
+1 |
@cms-sw/db-l2 could you please review and sign, if you think so, before there will be any need to rebase this PR, which touches so many files? |
+1 |
@smuzaffar, @silviodonato, @qliphy is the bot stuck? This PR is fully signed, but it does not show... |
+1 |
This was referenced Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The primary goal of this PR is to introduce a new DB object to store per-
DetId
Lorentz Angle calibration values for the Phase-2 Outer Tracker. A newCondFormat
calledSiPhase2OuterTrackerLorentzAngle
is introduced and used to populate the newly createdEventSetup
recordsSiPhase2OuterTrackerLorentzAngleRcd
andSiPhase2OuterTrackerLorentzAngleSimRcd
.The former is then used to provide the calibration to the Outer Tracker local reconstruction via
Phase2StripCPEE
, while the latter is used to provide the simulation Lorentz Angle to the Phase2 Tracker digitizer concrete implementations for the OT (PSPDigitizerAlgorithm
,PSSDigitizerAlgorithm
andSSDigitizerAlgorithm
).EventSetup
records are for the moment populated via an ad-hocESSource
calledSiPhase2OuterTrackerFakeLorentzAngleESSource
which can be used for both records, but eventually the input data will come fromCondDB
viaGlobalTag
once this PR is accepted. TheESSource
is percolated viafakePhase2OuterTrackerConditions_cff
to all the active phase-2 geometries.ESSource
is configured in such a way to produce same values of the hardcoded Lorentz Angles used so far in the Simulation and Local Reconstruction (wich is μH=0.07/T).TkStripCPERecord
by introducing a new dependent recordTkPhase2OTCPERecord
which goes in the spirit of what was proposed originally at Integrating VectorHits reconstruction for the Phase2 OT #28101. The new dependent record at the moment depends only on the Phase Outer Tracker LA, but will depend on more records as more pieces are added to the local reconstruction.TkPhase2OTCPERecord
is then subsequently percolated to the appropriate classes in Tracking.The changes proposed here have been discussed at the Tracker Phase-2 simulation meeting of May 22nd 2020, but have then been postponed to allow other urgent developments to enter the release.
PR validation:
The local branch passes the following workflows tests (one for each active geometry):
as well as the unit tests of the respective packages involved.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.
cc:
@emiglior @skinnari @tsusa @mtosi @JanFSchulte