-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SiPhase2OuterTrackerLorentzAngleRcd to GlobalTag #31259
Move SiPhase2OuterTrackerLorentzAngleRcd to GlobalTag #31259
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31259/17930
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Configuration/AlCa @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
Pull request #31259 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun, @kpedro88 can you please check and sign again. |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Now that #31095 is merged in a pre-release (
CMSSW_11_2_0_pre5
), the corresponding conditions for the reco and sim outer tracker Lorentz AngleSiPhase2OuterTrackerLorentzAngleRcd
andSiPhase2OuterTrackerLorentzAngleSimRcd
can be supplied directly from the Global TagESSource
, in lieu of a separateESProducer
.As the conditions are the same for all the currently supported Phase-2 Tracker Geometries, the new tags are included in the physical autoCond base GT for the key
auto:phase2_realistic
. If in future the values for different geometries need to diverge, these can be changed individually for each symbolic Global Tag inautoCondPhase2
.The Global Tag is at the moment a GT candidate, but can be changed to full-fledged GT if the AlCa/DB team can supply one, the difference in terms of tags is available here.
No physics changes are expected.
PR validation:
This branch passes the unit tests
scramv1 b runtests
as well asif this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.
attn: @trtomei