Shorten upgrade workflow names, reorganize premixing workflow setup and add to PR tests for phase 2 #30988
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30988/17439
|
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+upgrade |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
this is a bit misleading though: IIUC, all comparison jobs in the upgrade workflows, the ones that were changed by this PR (not just in reco, but also in relmon/DQM), have failed due to different directory names. |
|
Yes, maybe we need to add a line about "missing workflows"? In this case it's intentional, but in other cases it might not be... |
|
@chayanit, @wajidalikhan, @pgunnell I think this has finally converged, please take a look |
|
+1 |
|
+operations |
cmsbuild
added
fully-signed
operations-approved
and removed
operations-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
I think this broke the nanoAOD steps in workflows 11834.99, 12634.99, and 13034.99. |
|
see #31060 |
PR description:
The upgrade premixing workflow setup is reimplemented to use the special workflow approach. This reduces the number of hacks necessary (though a few are still needed). To facilitate this, PU steps are first added to the list and then specialized (this allows changing PU-related parameters).
The names of the premix workflows are adjusted slightly to try to keep the length down.
A new workflow is added for phase2 premixing using PU50 (rather than PU200, to reduce CPU/mem/disk usage). This will automatically generate PR comparison plots, which helps to test and validate PRs that impact Phase 2 premixing. The PU50 scenario used in this workflow only considers bunch crossings -3,3, as with the other phase 2 PU scenarios.
The upgrade workflow names are shortened by eliminating unnecessary words from step names (mostly 'Full'), and preventing the key and special workflow suffix (if any) from being repeated in the names. This also entails a small amount of reorganization in the order of information in the names (key and suffix now come first). The directory and display names were originally:
and are now reduced to:
PR validation:
Compared the commands generated by
runTheMatrix.py -w upgrade -l 23461.97,23461.98,23461.99 --dryRunbefore and after this PR to see that they contain the same flags. Also tested the commands for 23461.999.