Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Switch runtime to using specific revisions for vendored code #779

Closed
mcastelino opened this issue Oct 30, 2017 · 0 comments
Closed

Switch runtime to using specific revisions for vendored code #779

mcastelino opened this issue Oct 30, 2017 · 0 comments
Assignees

Comments

@mcastelino
Copy link
Contributor

Description of problem

virtcontainers has already switched to vendoring specific revisions of dependencies.

Switch the runtime to also adopt the same.

Expected result

This allows an user to do perform

rm -rf vendor 
dep ensure

without having to worry about unwanted changes being picked up.

The downside is that the revendoring becomes manual. It also requires that runtime dependency revisions match that the exact revision used by virtcontainers (which may be a good thing).

mcastelino added a commit to mcastelino/runtime that referenced this issue Oct 31, 2017
virtcontainers has already switched to vendoring specific revisions of dependencies.
Switch the runtime to also adopt the same.

This allows an user to do perform

rm -rf vendor
dep ensure

without having to worry about unwanted changes being picked up.

The downside is that the revendoring becomes manual. It also requires that runtime dependency
revisions match that the exact revision used by virtcontainers (which may be a good thing).

Fixes clearcontainers#779

Signed-off-by: Manohar Castelino <[email protected]>
mcastelino added a commit to mcastelino/runtime that referenced this issue Oct 31, 2017
virtcontainers has already switched to vendoring specific revisions of dependencies.
Switch the runtime to also adopt the same.

This allows an user to do perform

rm -rf vendor
dep ensure

without having to worry about unwanted changes being picked up.

The downside is that the revendoring becomes manual. It also requires that runtime dependency
revisions match that the exact revision used by virtcontainers (which may be a good thing).

Fixes clearcontainers#779

Signed-off-by: Manohar Castelino <[email protected]>
mcastelino added a commit to mcastelino/runtime that referenced this issue Oct 31, 2017
virtcontainers has already switched to vendoring specific revisions of dependencies.
Switch the runtime to also adopt the same.

This allows an user to do perform

rm -rf vendor
dep ensure

without having to worry about unwanted changes being picked up.

The downside is that the revendoring becomes manual. It also requires that runtime dependency
revisions match that the exact revision used by virtcontainers (which may be a good thing).

Fixes clearcontainers#779

Signed-off-by: Manohar Castelino <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants