This repository has been archived by the owner on May 6, 2020. It is now read-only.
Vendoring: Switch to fixed revision vendoring #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kubernetes qa-passed 👍 |
|
LGTM
|
virtcontainers has already switched to vendoring specific revisions of dependencies. Switch the runtime to also adopt the same. This allows an user to do perform rm -rf vendor dep ensure without having to worry about unwanted changes being picked up. The downside is that the revendoring becomes manual. It also requires that runtime dependency revisions match that the exact revision used by virtcontainers (which may be a good thing). Fixes clearcontainers#779 Signed-off-by: Manohar Castelino <[email protected]>
mcastelino
force-pushed
the
topic/vendoring
branch
from
57f7f85 to
82b491f
Compare
mcastelino
changed the title
mcastelino
changed the title
mcastelino
force-pushed
the
topic/vendoring
branch
from
82b491f to
774878a
Compare
|
kubernetes qa-passed 👍 |
1 similar comment
|
kubernetes qa-passed 👍 |
|
lgtm
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtcontainers has already switched to vendoring specific revisions of dependencies.
Switch the runtime to also adopt the same.
This allows an user to do perform
rm -rf vendor
dep ensure
without having to worry about unwanted changes being picked up.
The downside is that the revendoring becomes manual. It also requires that runtime dependency
revisions match that the exact revision used by virtcontainers (which may be a good thing).
Fixes #779
Signed-off-by: Manohar Castelino [email protected]