This repository has been archived by the owner on May 6, 2020. It is now read-only.
Networking: Revendor netlink and virtcontainers to support macvtap #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revendor netlink and virtcontainers to switch the default network connection method to use macvtap. Fixes clearcontainers#708 Fixes clearcontainers#709 Signed-off-by: Manohar Castelino <[email protected]>
|
@mcastelino I think we should stick the runtime vendoring to specific versions as we did for virtcontainers, WDYT ? |
I was thinking about that. The only downside (or upside) if you do that is that the revendoring becomes a more manual (but thoughtful process). I can do that in this PR if you want. |
|
kubernetes qa-passed 👍 |
|
@mcastelino, no I was mentioning this because I thought it would be good to have it. But I think this should be done in a separate PR so that it's not hidden behind netlink and virtcontainers revendoring. |
|
LGTM |
|
lgtm
|
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
virtcontainers: revert "fix shared dir resource remaining"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revendor netlink and virtcontainers to switch the default network connection method to use macvtap.
Fixes #708
Fixes #709
Signed-off-by: Manohar Castelino [email protected]