Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PfLO in IE 11 #3852

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Disable PfLO in IE 11 #3852

merged 4 commits into from
Feb 13, 2020

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow CKEditor 4 code style guide?

Your code should follow guidelines from CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with code style guide

What is the proposed changelog entry for this pull request?

None

What changes did you make?

This PR disables PfLO and its tests in IE. See ckeditor/ckeditor4-presets#30 (review) for more details.

@f1ames f1ames self-requested a review February 12, 2020 11:04
@f1ames f1ames self-assigned this Feb 12, 2020
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is red and some (same I think) tests fails locally too:

I think the leftover fixtures (for Safari, IE11s) are still usedin unit tests and breaks them.

@Comandeer Comandeer self-assigned this Feb 12, 2020
@Comandeer
Copy link
Member Author

Removed unnecessary fixtures.

@Comandeer Comandeer requested a review from f1ames February 12, 2020 17:06
@f1ames f1ames self-assigned this Feb 13, 2020
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@f1ames f1ames merged commit e4199cf into major Feb 13, 2020
@CKEditorBot CKEditorBot deleted the pflo-ie branch February 13, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants