Merge pull request #3844 from ckeditor/t/3835

Enable PfLO unit tests in IE11
ckeditor · Feb 10, 2020 · 6565b99 · 6565b99
2 parents e6c0015 + edeab33
commit 6565b99
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 4 deletions.
diff --git a/tests/plugins/pastefromlibreoffice/generated/generic.js b/tests/plugins/pastefromlibreoffice/generated/generic.js
@@ -16,7 +16,20 @@
 	};
 
 	var isSafari = CKEDITOR.env.webkit && !CKEDITOR.env.chrome,
-		isIE = CKEDITOR.env.ie && CKEDITOR.env.version <= 11;
+		isOldIE = CKEDITOR.env.ie && CKEDITOR.env.version < 11,
+		isIE11 = CKEDITOR.env.ie && CKEDITOR.env.version === 11,
+		// IE 11 does not support logical CSS properties.
+		customFilters = isIE11 ? [
+				new CKEDITOR.htmlParser.filter( {
+					attributes: {
+						style: function( attribute ) {
+							if ( attribute.indexOf( 'text-align:start' ) !== -1 ) {
+								return false;
+							}
+						}
+					}
+				} )
+			] : [];
 
 	bender.test( createTestSuite( {
 		browsers: [
@@ -42,6 +55,18 @@
 			Paragraph_format: true,
 			Page_break: true
 		},
-		ignoreAll: isSafari || isIE || bender.tools.env.mobile
+		testData: {
+			_should: {
+				// IE 11 generates borders differently than everyone else.
+				ignore: {
+					'test Table_background libreoffice6 chrome': isIE11,
+					'test Table_background libreoffice6 edge': isIE11,
+					'test Table_background libreoffice6 firefox': isIE11,
+					'test Table_background libreoffice6 safari': isIE11
+				}
+			}
+		},
+		ignoreAll: isSafari || isOldIE || bender.tools.env.mobile,
+		customFilters: customFilters
 	} ) );
 } )();
diff --git a/tests/plugins/pastefromlibreoffice/generated/genericwithword.js b/tests/plugins/pastefromlibreoffice/generated/genericwithword.js
@@ -16,7 +16,20 @@
 	};
 
 	var isSafari = CKEDITOR.env.webkit && !CKEDITOR.env.chrome,
-		isIE = CKEDITOR.env.ie && CKEDITOR.env.version <= 11;
+		isOldIE = CKEDITOR.env.ie && CKEDITOR.env.version < 11,
+		isIE11 = CKEDITOR.env.ie && CKEDITOR.env.version === 11,
+		// IE 11 does not support logical CSS properties.
+		customFilters = isIE11 ? [
+			new CKEDITOR.htmlParser.filter( {
+				attributes: {
+					style: function( attribute ) {
+						if ( attribute.indexOf( 'text-align:start' ) !== -1 ) {
+							return false;
+						}
+					}
+				}
+			} )
+		] : [];
 
 	bender.test( createTestSuite( {
 		browsers: [
@@ -42,6 +55,18 @@
 			Paragraph_format: true,
 			Page_break: true
 		},
-		ignoreAll: isSafari || isIE || bender.tools.env.mobile
+		testData: {
+			_should: {
+				// IE 11 generates borders differently than everyone else.
+				ignore: {
+					'test Table_background libreoffice6 chrome': isIE11,
+					'test Table_background libreoffice6 edge': isIE11,
+					'test Table_background libreoffice6 firefox': isIE11,
+					'test Table_background libreoffice6 safari': isIE11
+				}
+			}
+		},
+		ignoreAll: isSafari || isOldIE || bender.tools.env.mobile,
+		customFilters: customFilters
 	} ) );
 } )();