Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PfLO unit tests in IE11 #3844

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Enable PfLO unit tests in IE11 #3844

merged 1 commit into from
Feb 10, 2020

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Task

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow CKEditor 4 code style guide?

Your code should follow guidelines from CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with code style guide

What is the proposed changelog entry for this pull request?

None is needed

What changes did you make?

I've enabled PfLO unit tests in IE11 with necessary custom filters and ignoring fixtures.

Which issues your PR resolves?

Closes #3835.

@jacekbogdanski jacekbogdanski self-requested a review February 10, 2020 08:17
Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacekbogdanski jacekbogdanski merged commit 6565b99 into major Feb 10, 2020
@CKEditorBot CKEditorBot deleted the t/3835 branch February 10, 2020 09:37
Comandeer added a commit that referenced this pull request Feb 11, 2020
This reverts commit 6565b99, reversing
changes made to e6c0015.
Comandeer added a commit that referenced this pull request Feb 12, 2020
This reverts commit 6565b99, reversing
changes made to e6c0015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PfLO unit tests shouldn't be ignored in IE11
2 participants