Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserializing failures on package info files should not fail the choco run #1328

Closed
ferventcoder opened this issue Jun 7, 2017 · 1 comment
Closed

Deserializing failures on package info files should not fail the choco run #1328

ferventcoder opened this issue Jun 7, 2017 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Bug Customer
Milestone
0.10.7

Comments

@ferventcoder
Copy link
Member

When deserializing package files file, rarely you may run into this:

Error deserializing response of type chocolatey.infrastructure.app.domain.PackageFiles:
 '.', hexadecimal value 0x00, is an invalid character. Line 1, position 1.
@ferventcoder ferventcoder added this to the 0.10.7 milestone Jun 7, 2017
@ferventcoder ferventcoder self-assigned this Jun 7, 2017
@ferventcoder
Copy link
Member Author

Handle serializing issues as well - https://gist.github.com/choco-bot/061d2dde2f278b8c52074753af78d4eb#file-install-txt-L6617

@ferventcoder ferventcoder changed the title Deserializing failures with Package information should not fail the choco run Deserializing failures on package info files should not fail the choco run Jun 8, 2017
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
(GH-1328) Serialize/deserialize package files warnings
e2c4e9b 
Instead of defaulting to errorrs, silently have those warnings come up.
When installing the package, if the save of the files snapshot fails,
log a warning but allow the install to be successful.

This corrects seeing these kinds of errors:

~~~
Error deserializing response of type
chocolatey.infrastructure.app.domain.PackageFiles:
 '.', hexadecimal value 0x00, is an invalid character. Line 1, position
1.
~~~
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
Merge branch 'stable'
e96fb15 
* stable:
  (version) 0.10.7
  (doc) update CHANGELOG/nuspec
  (GH-1328) Serialize/deserialize package files warnings
  (maint) clean up install/uninstall template
  (GH-1330) Use $packageArgs in default uninstall script
  (GH-1323) File/File64 as params not aliases
  (GH-1324) requestedExecutionLevel = asInvoker
  (GH-1327) AutoUninstaller - split multiple file paths
  (maint) add parameter props to UseOriginalLocation
  (maint) formatting
  (GH-1323) rename file to downloadFilePath
  (GH-1325) List/Search - no fail on local directory
  (docs) add to PowerShell CONTRIBUTING
  (GH-1326) Always show heading
  (GH-976) Use Write-FunctionCallLogMessage
  (maint) formatting
  (GH-1322) Fix: search - exact ignores page/page-size
@kevinoid kevinoid mentioned this issue Jul 12, 2019
Closed
@ferventcoder ferventcoder mentioned this issue Aug 3, 2019
Open
@ferventcoder ferventcoder mentioned this issue Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Customer
Projects
None yet
Milestone
0.10.7
Development

No branches or pull requests
2 participants
@ferventcoder @gep13