Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Uninstaller doesn't split multiple paths #1327

Closed
ferventcoder opened this issue Jun 6, 2017 · 0 comments
Closed

Automatic Uninstaller doesn't split multiple paths #1327

ferventcoder opened this issue Jun 6, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Customer
Milestone
0.10.7

Comments

@ferventcoder
Copy link
Member

Say the uninstall string was specified like this: C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat

Running uninstall will produce the following message from automatic uninstaller:

2017-06-06 13:42:13,463 5244 [INFO ] -  Running auto uninstaller...
2017-06-06 13:42:13,463 5244 [DEBUG] -   Sleeping for 2 seconds to allow Windows to finish cleaning up.
2017-06-06 13:42:15,479 5244 [DEBUG] -  Preparing uninstall key 'C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat' for 'WinDirStat'
2017-06-06 13:42:15,479 5244 [DEBUG] -  Uninstaller path is 'C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat'
2017-06-06 13:42:15,495 5244 [INFO ] -  Skipping auto uninstaller - The uninstaller file no longer exists. "C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat"

This should be corrected.
@ferventcoder ferventcoder added this to the 0.10.6.2 milestone Jun 6, 2017
@ferventcoder ferventcoder self-assigned this Jun 6, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.6.2, 0.10.7 Jun 6, 2017
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
(GH-1327) AutoUninstaller - split multiple file paths
3aa140a 
Say the uninstall string was specified like this:
`C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat`

Running uninstall will produce the following message from automatic
uninstaller:

~~~sh
2017-06-06 13:42:13,463 5244 [INFO ] -  Running auto uninstaller...
2017-06-06 13:42:13,463 5244 [DEBUG] -   Sleeping for 2 seconds to
allow Windows to finish cleaning up.
2017-06-06 13:42:15,479 5244 [DEBUG] -  Preparing uninstall key
'C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat' for
'WinDirStat'
2017-06-06 13:42:15,479 5244 [DEBUG] -  Uninstaller path is
'C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat'
2017-06-06 13:42:15,495 5244 [INFO ] -  Skipping auto uninstaller - The
uninstaller file no longer exists.
"C:\Programs\WinDirStat\Uninstall.exe D:\Programs\WinDirStat"
~~~

Split the paths when multiple `:` are detected.
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
Merge branch 'stable'
e96fb15 
* stable:
  (version) 0.10.7
  (doc) update CHANGELOG/nuspec
  (GH-1328) Serialize/deserialize package files warnings
  (maint) clean up install/uninstall template
  (GH-1330) Use $packageArgs in default uninstall script
  (GH-1323) File/File64 as params not aliases
  (GH-1324) requestedExecutionLevel = asInvoker
  (GH-1327) AutoUninstaller - split multiple file paths
  (maint) add parameter props to UseOriginalLocation
  (maint) formatting
  (GH-1323) rename file to downloadFilePath
  (GH-1325) List/Search - no fail on local directory
  (docs) add to PowerShell CONTRIBUTING
  (GH-1326) Always show heading
  (GH-976) Use Write-FunctionCallLogMessage
  (maint) formatting
  (GH-1322) Fix: search - exact ignores page/page-size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Customer
Projects
None yet
Milestone
0.10.7
Development

No branches or pull requests
2 participants
@ferventcoder @gep13