Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file/file64 not as aliases, but use them to set url/url64 if empty #1323

Closed
ferventcoder opened this issue Jun 4, 2017 · 0 comments
Closed

Add file/file64 not as aliases, but use them to set url/url64 if empty #1323

ferventcoder opened this issue Jun 4, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.10.7

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Jun 4, 2017 •
edited
Loading

Adding these as aliases can provide even more confusion if someone has specified url and file in package parameters. A happy medium is to have both parameters, preferring url/url64bit over file/file64.

Related to #1284

Reference: https://groups.google.com/d/msgid/chocolatey/f9fa1bdd-ff2b-4106-b87f-c189fa5b348a%40googlegroups.com
@ferventcoder ferventcoder modified the milestones: 0.10.7, 0.10.6.2 Jun 4, 2017
@ferventcoder ferventcoder self-assigned this Jun 4, 2017
@ferventcoder ferventcoder changed the title Add file/file64 not as aliases, but use them to set aliases Add file/file64 not as aliases, but use them to set url/url64 if empty Jun 4, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.6.2, 0.10.7 Jun 6, 2017
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
(GH-1323) rename file to downloadFilePath
67f8ac5
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
(GH-1323) File/File64 as params not aliases
a71767c 
File and File64 were added as aliases to `Url`/`Url64bit` in 0.10.6 to
add compatibility, but they actually introduced more incompatibilities
instead of addressing them due to being aliases. Move them to
parameters and set the values if the original values are empty.

NOTE: This could still cause a small incompatibility if someone is
attempting to use both File and Url in a single set of package
parameters but apply it to multiple function calls. Fortunately it
typically means they will have filled out both items, which means those
functions should still continue to work as they have in the past.
ferventcoder added a commit that referenced this issue Jun 8, 2017
@ferventcoder
Merge branch 'stable'
e96fb15 
* stable:
  (version) 0.10.7
  (doc) update CHANGELOG/nuspec
  (GH-1328) Serialize/deserialize package files warnings
  (maint) clean up install/uninstall template
  (GH-1330) Use $packageArgs in default uninstall script
  (GH-1323) File/File64 as params not aliases
  (GH-1324) requestedExecutionLevel = asInvoker
  (GH-1327) AutoUninstaller - split multiple file paths
  (maint) add parameter props to UseOriginalLocation
  (maint) formatting
  (GH-1323) rename file to downloadFilePath
  (GH-1325) List/Search - no fail on local directory
  (docs) add to PowerShell CONTRIBUTING
  (GH-1326) Always show heading
  (GH-976) Use Write-FunctionCallLogMessage
  (maint) formatting
  (GH-1322) Fix: search - exact ignores page/page-size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.10.7
Development

No branches or pull requests
2 participants
@ferventcoder @gep13