Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compat tests again. #47

Closed
dumol opened this issue Jul 6, 2023 · 0 comments · Fixed by #69
Closed

Enable compat tests again. #47

dumol opened this issue Jul 6, 2023 · 0 comments · Fixed by #69
Assignees

Comments

@dumol
Copy link
Contributor

dumol commented Jul 6, 2023

Run the compat tests for the current branches as well, now that the compat repo has been updated to use latest 3.11 released packages. I have attempted this as a drive-by in #45, but it's not that simple…

It looks like the Docker setup needs to be updated to run under a regular user with sudo powers, as set up in the compat repo: https://github.com/chevah/compat/blob/master/.github/workflows/docker.yml#L69.

A starting diff:

diff --git a/.github/workflows/bare.yaml b/.github/workflows/bare.yaml
index 2305758..de64645 100644
--- a/.github/workflows/bare.yaml
+++ b/.github/workflows/bare.yaml
@@ -42,6 +42,9 @@ jobs:
     - name: Test Pythia
       run: bash ./build.sh test

+    - name: Compat tests
+      run: bash ./build.sh compat
+
     # To use an RSA key with SFTPPlus, install upstream OpenSSH package,
     # which is more finicky in regards to file permissions.
     # Beware the commands in this step run under PowerShell.
@@ -114,6 +117,9 @@ jobs:
     - name: Test Pythia
       run: ./build.sh test

+    - name: Compat tests
+      run: ./build.sh compat
+
     - name: Upload testing package
       run: |
         mkdir -pv ~/.ssh/
@@ -144,6 +150,9 @@ jobs:
     - name: Test Pythia
       run: ./build.sh test

+    - name: Compat tests
+      run: ./build.sh compat
+
     - name: Upload testing package
       run: |
         mkdir -pv ~/.ssh/
diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml
index cc57e5b..db3c51f 100644
--- a/.github/workflows/docker.yaml
+++ b/.github/workflows/docker.yaml
@@ -74,6 +74,11 @@ jobs:
         cd pythia
         ./build.sh test

+    - name: Compat tests
+      run: |
+        cd pythia
+        ./build.sh compat
+
     # Using `~/` is problematic under Docker, use `/root/`.
     # Remove key in same step to avoid leaving it on disk if publishing fails.
     - name: Upload testing package
diff --git a/pythia.conf b/pythia.conf
index 0318320..91b17ad 100644
--- a/pythia.conf
+++ b/pythia.conf
@@ -1,12 +1,14 @@
 PYTHON_NAME="python3.11"
 PYTHON_CONFIGURATION="[email protected]"
 # This is defined as a Bash array of options to be passed to commands.
-BASE_REQUIREMENTS=(chevah-brink==1.0.9 paver==1.2.4)
-# Use our production server instead of the GitHub releases set by default.
+BASE_REQUIREMENTS=("chevah-brink==1.0.10" "paver==1.3.4" "wheel")
+# Use our public production server by default.
 BINARY_DIST_URI="https://bin.chevah.com:20443/production"
-# For testing packages, make sure this one is the last uncommented instance:
+# GitHub releases is a backup option.
+#BINARY_DIST_URI="https://github.com/chevah/pythia/releases/download"
+# When using testing packages, this should be the last uncommented instance:
 #BINARY_DIST_URI="https://bin.chevah.com:20443/testing"
-# Also overwrite the default pypi.org site set by default in pythia.sh.
+# Overwrite the upstream pypi.org site set by default in pythia.sh.
 PIP_INDEX_URL="https://bin.chevah.com:20443/pypi/simple"
 # This is used by the Python runtime.
-CHEVAH_BUILD_DIR="build-pythia"
+CHEVAH_BUILD_DIR="build-py3"
@dumol dumol self-assigned this Jul 6, 2023
@dumol dumol closed this as completed in #69 Nov 25, 2024
dumol added a commit that referenced this issue Nov 25, 2024
* Use production packages.

* Updated populating cache for compat tests.

* Readded compat tests through GHA.

* Readded compat tests through GHA, take 2.

* Readded compat tests through GHA, take 3.

* Run docker builds and tests as a regular user.

* Run docker builds and tests as a regular user, take 2

* Run docker builds and tests as a regular user, take 3

* Run docker builds and tests as a regular user, take 4

* Run docker builds and tests as a regular user, take 5

* Put paxctl where it's easier to find.

* Also try test_ci2 compat tests.

* Install sudo for elevated tests.

* Final tweaks.

* Final tweaks, take 2.

* Final tweaks, take 3.

* Changes after own review.

* Changes after own review, take two.

* Changes after own review, take three.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant