[#695] Update for latest Twisted. #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 79.47% 78.58% -0.89%
==========================================
Files 52 51 -1
Lines 7800 7761 -39
Branches 1275 1171 -104
==========================================
- Hits 6199 6099 -100
- Misses 1333 1379 +46
- Partials 268 283 +15 see 45 files with indirect coverage changes
|
|
needs-review |
ACK. here's also an issue for re-enabling the compat tests in Pythia: chevah/pythia#47. I guess we'll only manage to do it selectively. changes-approved |
dumol
approved these changes
Jul 5, 2024
|
Thanks. I will merge this and we can create a separate PR to see what's missing for pythia. THe idea iwith the docker tests from chevah/compat is to run the exact same tests exected to be executed by Pyhtia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #695
This is here to support latest Twisted version.
Changes
Fix testing of Twisted reactor.
As a drive-by update the python version.
Docker tests for Amazon LInux 2 was removed due to glibc issues
Testing for macOS is now only on M1... as we no longer have x64 Python wheel packages for macos AMD64
How to try and test the changes
reviewers: @dumol
More of a FYI for the environments for which we run tests for compat.
This is to make sure the tests in compat are compatible with the kind of testing done in Pythia