Enable upstream Python tests.

[dumol]

Scope

Fixes #12

Changes

Enabled the Python tests on the platforms where we build it, with the exception of:

• Alpine Linux
• macOS.

Drive-by fixes:

• fixed enabling EMUTRAMP on Alpine with paxctl.
• fixed the execution of Shellcheck tests.
• fixed minor Shellcheck warnings.
• use dedicated chevabs functions for testing and installing to have them listed distinctly in GHA output.
• enabled upstream tests for libffi, bzip2, xz, zlib.

Testing

Automated.

[dumol]

Not sure what do about macOS, haven't invested much time into it. If you want to, take a look, maybe some things are worth reporting upstream.

Otherwise, I would just except macOS alongside Alpine Linux.

[adiroiban]

it's ok to except macOS.

thanks

[dumol]

Sorry for the Shellcheck drive-by fixes, it looks like they weren't run at all in master because of a late "improvement" in the previous PR. :-/

I have now used execute for ./src/chevah-bash-tests/shellcheck_tests.sh, should not happen again…

One thing to keep in mind is that the only platform running all tests (upstream ones for OpenSSL/Python + ours for Python&modules + security check with safety + bash shell checks) is glibc-based Linux. You could argue Windows is also fully covered, as we use the upstream Python/OpenSSL/cryptography, so there's no need to test what upstream has built.

[adiroiban]

I guess that it's ok.

I don't know where to check the result in GHA.

I was expecting to see it as a separate GHA step or at least as part of Pythia tests

My reading the code, this is mixed with compiling Python... which is a huge output, which is hard to check

My preference, is to have "Pythion test" as a separate top level step.

Thanks

[adiroiban]

can we have this as a separate command?

The command is "compile" , but this is not compile + test.

I think it's easier if we have a separate command.

And we can skip calling the test based on the GHA yaml files

[dumol]

I've added dedicated a chevahbs function for testing.

This testing is now listed distinctly in GHA output, alongside building and installing (installing can also be quite verbose, e.g. for OpenSSL and Python).

[dumol]

My reading the code, this is mixed with compiling Python... which is a huge output, which is hard to check

I've worked on separating testing in a dedicated GHA step. Same for installing.

My preference, is to have "Pythion test" as a separate top level step.

It is a separate test, but not a top-level one. I think this kind of testing is best done where it belongs, right after compiling, but before installing. This way, if testing fails, the build is stopped right there, no need to continue with building other libraries.

[adiroiban]

I think that this can be merged. thanks!