notifications slack integration broken image fix

[susanev]

🔩 Description: What code changed, and why?

there was a broken image in the notifications service, we are gonna use this one instead https://docs.chef.io/images/chef-icon.png h/t @mjingle

⛓️ Related Resources

fixes #3602

👍 Definition of Done

no more broken image url

👟 How to Build and Test the Change

i dont super know how to test this, hopefully @satellite15 does

✅ Checklist

• I have read the CONTRIBUTING document.
• Tests added/updated?
• Docs added/updated?
• All commits have been signed-off for the Developer Certification of Origin.

📷 Screenshots, if applicable

zero.

[susanev]

no clue why im breaking doc shortcodes??

[schisamo]

Is there a way we can bake this image into the service? I don't want to hold up fixing this broken image but maybe we should have a follow-on PR which doesn't pull the image from an external location.

[susanev]

@schisamo i was under the assumption that it needed to be external because its used in the slack integration... @satellite15 can it be internal to the service?

[satellite15]

I can't reproducing this. I see the icon on my slack channel before and after the fix.
In both cases it only appears on the first alert and not subsequent alerts.

I see the icon in the slack alerts before and after the fix.

And the URL is in s3.
before https://s3-us-west-2.amazonaws.com/slack-files2/bot_icons/2017-02-17/143310324690_48.png

after https://s3-us-west-2.amazonaws.com/slack-files2/bot_icons/2020-05-08/1136159172752_48.png

I'm guessing slack stores the images and doesn't link to the original and that's why it appears to be working before and after the fix.

I wold say push the new fix. And yes @schisamo keep it external to the service. It needs to be public and accessible by slack so should be a static resource outside of automate.