Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications slack integration broken image fix #3604

Merged
merged 2 commits into from
May 8, 2020
Merged

notifications slack integration broken image fix #3604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d181f
trying to fix broken image
susanev May 6, 2020
7bba70e
removed image
susanev May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/notifications-service/server/lib/formatters/slack.compliance.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ defmodule Notifications.Formatters.Slack.Compliance do
"InSpec found a critical control failure on node #{c.node_name}")
%{
username: "Chef Automate",
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: msg,
attachments: [attachment_note(c)],
}
Expand Down
2 changes: 1 addition & 1 deletion components/notifications-service/server/lib/formatters/slack.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ defmodule Notifications.Formatters.Slack do
def format(%{__struct__: type} = n) when type in [CCRFailure, CCRSuccess] do
payload = Message.new(
username: "Chef Automate",
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
attachments: [attachment_note(n)],
text: alert_text(n)
)
Expand Down
8 changes: 4 additions & 4 deletions components/notifications-service/server/test/formatters/slack.compliance_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ defmodule Notifications.Formatters.Slack.Compliance.Test do
mrkdwn_in: ["text", "pretext"],
text: "```expected File /etc/ssh not to be readable by others```\n"
}],
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: "<https://localhost/compliance/reporting/nodes/deadbeef05|InSpec found a critical control failure on node pretty-chipper-node>",
username: "Chef Automate"
}
Expand Down Expand Up @@ -52,7 +52,7 @@ defmodule Notifications.Formatters.Slack.Compliance.Test do
mrkdwn_in: ["text", "pretext"],
text: "```2 of 3 tests failed. View in Chef Automate for full details.```\n"
}],
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: "<https://localhost/compliance/reporting/nodes/deadbeef04|InSpec found a critical control failure on node unhappy-node>",
username: "Chef Automate"
}
Expand Down Expand Up @@ -81,7 +81,7 @@ defmodule Notifications.Formatters.Slack.Compliance.Test do
mrkdwn_in: ["text", "pretext"],
text: "```2 of 3 tests failed. View in Chef Automate for full details.```\n"
}],
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: "<https://localhost/compliance/reporting/nodes/deadbeef03|InSpec found a critical control failure on node sad-node>",
username: "Chef Automate"
}
Expand Down Expand Up @@ -110,7 +110,7 @@ defmodule Notifications.Formatters.Slack.Compliance.Test do
mrkdwn_in: ["text", "pretext"],
text: "```97 of 174 tests failed. View in Chef Automate for full details.```\n"
}],
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: "<https://localhost/compliance/reporting/nodes/deadbeef06|InSpec found a critical control failure on node failing-node>",
username: "Chef Automate"
}
Expand Down
2 changes: 1 addition & 1 deletion components/notifications-service/server/test/formatters/slack_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ defmodule Notifications.Formatters.Slack.Test do
Line: 26```
""")
}],
icon_url: "https://docs.chef.io/_static/chef_logo_v2.png",
icon_url: "https://docs.chef.io/images/chef-icon.png",
text: "<https://localhost/nodes/0271e125-97dd-498a-b026-8448ee60aafe/runs/ba6acb91-1eaa-4c84-8d68-f19ee641e606|Chef client run failure on insights.chef.co>\n",
username: "Chef Automate"
}
Expand Down