Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image URL included in Slack integration returns 404 #3602

Closed
jasonwbarnett opened this issue May 6, 2020 · 4 comments · Fixed by #3604
Closed

Image URL included in Slack integration returns 404 #3602

jasonwbarnett opened this issue May 6, 2020 · 4 comments · Fixed by #3604
Labels
bug 🐛 Something isn't working community issues submitted by community folks notifications This issue or pull request pertains to notifications in Automate

Comments

@jasonwbarnett
Copy link

Describe the bug

When using the Slack integration, the icon_url provided returns a 404.

URL: https://docs.chef.io/_static/chef_logo_v2.png

To Reproduce

  • Setup Slack integration
  • See the JSON body includes a URL to a missing image

Expected behavior

  • Expect the url provided in icon_url to actual resolve to an image that is accessible.
@jasonwbarnett jasonwbarnett added the bug 🐛 Something isn't working label May 6, 2020
@susanev susanev added needs-triage community issues submitted by community folks labels May 6, 2020
@jasonwbarnett jasonwbarnett changed the title Image included in Slack integration is not resolvable Image URL included in Slack integration returns 404 May 6, 2020
@jasonwbarnett
Copy link
Author

If someone can point me to the right URL, I'd gladly submit a fix.

@susanev
Copy link
Contributor

susanev commented May 6, 2020

was just looking, we dont seem to have a hosted version of only the logo without the text. im adding one now.

@susanev susanev mentioned this issue May 6, 2020
Merged
4 tasks
@susanev susanev added notifications This issue or pull request pertains to notifications in Automate and removed needs-triage labels May 6, 2020
@susanev
Copy link
Contributor

susanev commented May 6, 2020

@jasonwbarnett thanks for reporting this! we got a new image added. it wont make it into the next release but will be in the one after that which should happen on monday, may 18th if everything stays on schedule.

pr: #3604

@susanev
Copy link
Contributor

susanev commented May 8, 2020

should be fixed in the release on monday may 18th

@snyk-bot snyk-bot mentioned this issue Jan 25, 2022
Open
This was referenced Oct 30, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working community issues submitted by community folks notifications This issue or pull request pertains to notifications in Automate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notifications slack integration broken image fix chef/automate
2 participants
@jasonwbarnett @susanev