Light up an additional typescript template check #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SEAjamieD
reviewed
Apr 28, 2020
| @@ -1,5 +1,6 @@ | |||
| import { Component, OnInit, OnDestroy, EventEmitter } from '@angular/core'; | |||
| import { FormBuilder, FormGroup, Validators } from '@angular/forms'; | |||
| import { MatOptionSelectionChange } from '@angular/material/core/option'; | |||
SEAjamieD
approved these changes
Apr 28, 2020
msorens
force-pushed
the
ms/add-typescript-check
branch
2 times, most recently
from
3a63231 to
fe1c159
Compare
srenatus
approved these changes
May 4, 2020
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
msorens
force-pushed
the
ms/add-typescript-check
branch
from
fe1c159 to
4531e0d
Compare
|
Note to self: this was delayed in merging because of an error that manifested in both ...and in I had tried to find the cause of those but without much joy. Finally, when I rebased today--a couple weeks later--all tests reported green. Just to make sure it was not a fluke, I reran buildkite again. And again. All passes! So now I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Follow-on to Angular 9 template type checking enablement, this throws the switch on one more check--and fixes the problems it reveals.
⛓️ Related Resources
PR #3268 Turn on strict Angular checks
👍 Definition of Done
ng buildis clean with an additional check activated👟 How to Build and Test the Change
Run
ng build✅ Checklist