Turn on strict Angular checks that pass #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already clean in the code base, requiring no code fixes. Signed-off-by: michael sorens <[email protected]>
SEAjamieD
approved these changes
Apr 2, 2020
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
We recently activated what I refer to as "level one" type checking via
fullTemplateTypeCheck(see PR #3230). This PR starts to address "level two", which would include the single checkstrictInjectionParameters(not clear why this one is separate 🤷♂ ) andstrictTemplates, which comprises a group of checks. We are not yet ready forstrictTemplatesbecause it reports quite a lot of issues to address, so instead I have itemized its components in the config file and this PR turns on all the ones that are already clean in the code base, requiring no code fixes.⛓️ Related Resources
👍 Definition of Done
Buildkite passes
👟 How to Build and Test the Change
Run
ng build-- should present no errors.✅ Checklist