Light up typescript check: strictDomLocalRefTypes #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: michael sorens <[email protected]>
srenatus
approved these changes
Jul 6, 2020
tarablack01
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Follow-on to Angular 9 template type checking enablement, this throws the switch on one more check.
This was an easy win--no collateral to fix after turning it on!
⛓️ Related Resources
PR #3268 Turn on strict Angular checks
PR #3158 Light up an additional typescript template check
👍 Definition of Done
ng buildreports no errors or warnings👟 How to Build and Test the Change
NA
✅ Checklist