Skip to content

Commit

Permalink
Swap in correct event type in component tests
Browse files Browse the repository at this point in the history
Signed-off-by: michael sorens <[email protected]>
  • Loading branch information
msorens committed May 1, 2020
1 parent 44da7fc commit fe1c159
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 15 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
import { MatOptionSelectionChange } from '@angular/material/core/option';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { RouterTestingModule } from '@angular/router/testing';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
Expand All @@ -14,7 +15,6 @@ import {
} from 'app/entities/teams/team.actions';
import { TeamManagementComponent } from './team-management.component';
import { FeatureFlagsService } from 'app/services/feature-flags/feature-flags.service';
import { ChefKeyboardEvent } from 'app/types/material-types';

describe('TeamManagementComponent', () => {
let component: TeamManagementComponent;
Expand Down Expand Up @@ -114,8 +114,7 @@ describe('TeamManagementComponent', () => {

describe('delete team', () => {
let store: Store<NgrxStateAtom>;
const mockChefKeyEvent = new KeyboardEvent('keypress') as ChefKeyboardEvent;
mockChefKeyEvent.isUserInput = true;
const mockEvent = { isUserInput: true } as MatOptionSelectionChange;

const deleteTeam: Team = {
guid: 'uuid-1',
Expand All @@ -134,7 +133,7 @@ describe('TeamManagementComponent', () => {
});

it('opens the delete modal', () => {
component.startTeamDelete(mockChefKeyEvent, deleteTeam);
component.startTeamDelete(mockEvent, deleteTeam);
fixture.detectChanges();

expect(component.deleteModalVisible).toBe(true);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { RouterTestingModule } from '@angular/router/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { MatOptionSelectionChange } from '@angular/material/core/option';
import { StoreModule, Store } from '@ngrx/store';
import { MockComponent } from 'ng2-mock-component';

Expand All @@ -16,7 +17,6 @@ import {
} from 'app/entities/projects/project.actions';
import { Project } from 'app/entities/projects/project.model';
import { ProjectListComponent } from './project-list.component';
import { ChefKeyboardEvent } from 'app/types/material-types';

describe('ProjectListComponent', () => {
let component: ProjectListComponent;
Expand Down Expand Up @@ -150,16 +150,15 @@ describe('ProjectListComponent', () => {
});

describe('delete modal', () => {
const mockChefKeyEvent = new KeyboardEvent('keypress') as ChefKeyboardEvent;
mockChefKeyEvent.isUserInput = true;
const mockEvent = { isUserInput: true } as MatOptionSelectionChange;

using([
['NO_RULES'],
['PROJECT_RULES_STATUS_UNSET']
], function (status: ProjectStatus) {
it(`upon selecting delete from control menu, opens with ${status}`, () => {
expect(component.deleteModalVisible).toBe(false);
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', status));
component.startProjectDelete(mockEvent, genProject('uuid-111', status));
expect(component.deleteModalVisible).toBe(true);
});
});
Expand All @@ -170,13 +169,13 @@ describe('ProjectListComponent', () => {
], function (status: ProjectStatus) {
it(`upon selecting delete from control menu, does not open with ${status}`, () => {
expect(component.deleteModalVisible).toBe(false);
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', status));
component.startProjectDelete(mockEvent, genProject('uuid-111', status));
expect(component.deleteModalVisible).toBe(false);
});
});

it('closes upon sending request to back-end', () => {
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', 'NO_RULES'));
component.startProjectDelete(mockEvent, genProject('uuid-111', 'NO_RULES'));
expect(component.deleteModalVisible).toBe(true);
component.deleteProject();
expect(component.deleteModalVisible).toBe(false);
Expand All @@ -185,16 +184,15 @@ describe('ProjectListComponent', () => {
});

describe('message modal', () => {
const mockChefKeyEvent = new KeyboardEvent('keypress') as ChefKeyboardEvent;
mockChefKeyEvent.isUserInput = true;
const mockEvent = { isUserInput: true } as MatOptionSelectionChange;

using([
['RULES_APPLIED'],
['EDITS_PENDING']
], function (status: ProjectStatus) {
it(`upon selecting delete from control menu, opens with ${status}`, () => {
expect(component.messageModalVisible).toBe(false);
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', status));
component.startProjectDelete(mockEvent, genProject('uuid-111', status));
expect(component.messageModalVisible).toBe(true);
});
});
Expand All @@ -205,13 +203,13 @@ describe('ProjectListComponent', () => {
], function (status: ProjectStatus) {
it(`upon selecting delete from control menu, does not open with ${status}`, () => {
expect(component.messageModalVisible).toBe(false);
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', status));
component.startProjectDelete(mockEvent, genProject('uuid-111', status));
expect(component.messageModalVisible).toBe(false);
});
});

it('closes upon request', () => {
component.startProjectDelete(mockChefKeyEvent, genProject('uuid-111', 'EDITS_PENDING'));
component.startProjectDelete(mockEvent, genProject('uuid-111', 'EDITS_PENDING'));
expect(component.messageModalVisible).toBe(true);
component.closeMessageModal();
expect(component.messageModalVisible).toBe(false);
Expand Down

0 comments on commit fe1c159

Please sign in to comment.