bugInfo.getColumn() is returning negative values in some cases #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugInfo.getColumn() is returning negative values in some cases, ensure when output to text is does not return a negative column.
|
Can you post an example case in #522? I only found instances where the column was greater than the valid range. It would be best to have them be correct in the first place than to have this kind of workaround be necessary. |
|
I tend to agree, fix the problem not the side affects, but this was causing an issue with the Sublime Linter not showing the respective matches that have a negative column. Easy enough to see the ones that are still failing where they are now "0". |
|
By the way, PRs should be made against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugInfo.getColumn() is returning negative values in some cases, ensure when output to text is does not return a negative column.