Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offsets more accurate #570

Open
ryaneberly opened this issue May 28, 2018 · 2 comments
Open

Make offsets more accurate #570

ryaneberly opened this issue May 28, 2018 · 2 comments
Assignees
Milestone

Comments

@ryaneberly
Copy link
Contributor

No description provided.

@ryaneberly ryaneberly self-assigned this May 28, 2018
ryaneberly added a commit that referenced this issue May 28, 2018
ryaneberly added a commit that referenced this issue May 28, 2018
ryaneberly added a commit that referenced this issue May 28, 2018
ryaneberly added a commit that referenced this issue May 28, 2018
ryaneberly added a commit that referenced this issue May 28, 2018
ryaneberly added a commit that referenced this issue May 29, 2018
ryaneberly added a commit that referenced this issue May 29, 2018
ryaneberly added a commit that referenced this issue May 29, 2018
@ryaneberly ryaneberly added this to the 1.5.0 milestone Jun 1, 2018
@ryaneberly
Copy link
Contributor Author

closing this and leaving #622 open

@KamasamaK
Copy link
Collaborator

#622 is only preventing column from being negative, which as I say in the comment on that PR doesn't solve the core problem. It also doesn't help offsets at all, which is what this issue was for.

@ryaneberly Did you actually mean #522? I think your keyboard is going a bit crazy lately. First there was the unrelated commit message for 5c34f3b which doesn't have a single number in common with the actual issue and then there's the crazy commit message with 5e6275c.

@KamasamaK KamasamaK reopened this Mar 18, 2020
@KamasamaK KamasamaK modified the milestones: 1.5.0, 1.5.1, 1.6.0 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants