Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugInfo.getColumn() is returning negative values in some cases #622

Merged
merged 4 commits into from
Jun 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 48 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,45 @@
# CHANGE LOG
# CHANGE LOG

## [1.4.0](https://github.com/cflint/CFLint/tree/1.4.0) (2018-05-27)

## [CFLint-1.4.1](https://github.com/cflint/CFLint/tree/CFLint-1.4.1) (2018-09-28)
[Full Changelog](https://github.com/cflint/CFLint/compare/CFLint-1.4.0...CFLint-1.4.1)

**Implemented enhancements:**

- OSGI support [\#588](https://github.com/cflint/CFLint/issues/588)
- Support for Safe Navigation Operator [\#579](https://github.com/cflint/CFLint/issues/579)
- command line " -folder .\ " doesn't match any files, " -folder .\views " does [\#576](https://github.com/cflint/CFLint/issues/576)
- Add queryExecute to QueryParamChecker [\#554](https://github.com/cflint/CFLint/issues/554)
- UNUSED\_METHOD\_ARGUMENT: Case not being retained [\#545](https://github.com/cflint/CFLint/issues/545)
- Inconsistent ALLCAPS [\#544](https://github.com/cflint/CFLint/issues/544)
- CommandBox integration [\#310](https://github.com/cflint/CFLint/issues/310)

**Fixed bugs:**

- Argument-/ComponentNameChecker ignores parameter-override "maxWords" [\#587](https://github.com/cflint/CFLint/issues/587)
- ArrayIndexOutOfBoundsException errors [\#583](https://github.com/cflint/CFLint/issues/583)
- UNUSED\_LOCAL\_VARIABLE false positive when used in new object initialization [\#577](https://github.com/cflint/CFLint/issues/577)
- MISSING\_VAR not triggering for tags in script [\#574](https://github.com/cflint/CFLint/issues/574)
- getting false positives on escaped pounds [\#571](https://github.com/cflint/CFLint/issues/571)
- PARSE\_ERROR unable to parse [\#547](https://github.com/cflint/CFLint/issues/547)
- Parameters not being passed into results?? [\#543](https://github.com/cflint/CFLint/issues/543)
- VAR\_INVALID\_NAME for scoped variable [\#537](https://github.com/cflint/CFLint/issues/537)
- Strange PARSE\_ERROR [\#536](https://github.com/cflint/CFLint/issues/536)
- -quiet reports some internal parsing/ANTLR messaging [\#526](https://github.com/cflint/CFLint/issues/526)

**Closed issues:**

- Find not english code. [\#585](https://github.com/cflint/CFLint/issues/585)
- Upgrade cfparser dependency to 2.7.0 [\#575](https://github.com/cflint/CFLint/issues/575)
- hanging producing report [\#459](https://github.com/cflint/CFLint/issues/459)
- Document CFLint contribution/build/test/play with process [\#317](https://github.com/cflint/CFLint/issues/317)

**Merged pull requests:**

- \#588 [\#591](https://github.com/cflint/CFLint/pull/591) ([ryaneberly](https://github.com/ryaneberly))
- Release 1.4.1 b [\#590](https://github.com/cflint/CFLint/pull/590) ([ryaneberly](https://github.com/ryaneberly))

## [CFLint-1.4.0](https://github.com/cflint/CFLint/tree/1.4.0) (2018-05-27)
[Full Changelog](https://github.com/cflint/CFLint/compare/CFLint-1.3.0...1.4.0)

**Implemented enhancements:**
Expand Down Expand Up @@ -655,4 +694,10 @@

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
9 changes: 8 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<cfparser.version>2.7.0</cfparser.version>
<cfparser.version>2.8.0</cfparser.version>
<jackson.version>2.8.6</jackson.version>
<slf4j.version>1.7.21</slf4j.version>
</properties>
Expand Down Expand Up @@ -196,6 +196,13 @@
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Bundle-Name>CFLint</Bundle-Name>
<Bundle-SymbolicName>com.cflint.CFLint</Bundle-SymbolicName>
<Bundle-Description>CFLint</Bundle-Description>
<Bundle-ManifestVersion>2</Bundle-ManifestVersion>
<Bundle-Version>${project.version}</Bundle-Version>
</manifestEntries>
</archive>
</configuration>
</plugin>
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/cflint/TextOutput.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ public void output(final BugList bugList, final Writer sb, CFLintStats stats) th
for (final BugInfo bugInfo : bugEntry.getValue()) {
final String severity = bugEntry.getValue().get(0).getSeverity().toString();
final String code = bugEntry.getValue().get(0).getMessageCode();
final Integer column = bugInfo.getColumn();
sb.append(NEW_LINE).append("Severity:").append(severity);
sb.append(NEW_LINE).append("Message code:").append(code);
sb.append(NEW_LINE).append("\tFile:").append(bugInfo.getFilename());
sb.append(NEW_LINE).append("\tColumn:").append(Integer.toString(bugInfo.getColumn()));
sb.append(NEW_LINE).append("\tColumn:").append(Integer.toString(column > -1 ? column : 0));
sb.append(NEW_LINE).append("\tLine:").append(Integer.toString(bugInfo.getLine()));
sb.append(NEW_LINE).append("\t\tMessage:").append(bugInfo.getMessage());
sb.append(NEW_LINE).append("\t\tVariable:'").append(bugInfo.getVariable());
Expand Down