Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload static VM testnet nodes, add stackdriver logging #750

Merged
merged 6 commits into from
Oct 3, 2019

Conversation

tkporter
Copy link
Contributor

Description

This uploads static VM tx-node enodes to google cloud, and also sets up the docker containers to send logs to Stackdriver.

Tested

I was able to create a VM testnet and run a fully functioning wallet app on it! 🎉
I also made sure the logs are being received and was able to create logging metrics & set up corresponding alerts

Other changes

Noticed a typo along the way in packages/protocol/truffle.js having to do with the alfajoresstaging faucet address, so I fixed that

Related issues

Backwards compatibility

Everything is backwards compatible

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files         261      261           
  Lines        7599     7599           
  Branches      440      440           
=======================================
  Hits         5028     5028           
  Misses       2476     2476           
  Partials       95       95
Flag Coverage Δ
#mobile 66.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96cbe2d...304f875. Read the comment docs.

@ashishb ashishb closed this Sep 24, 2019
@ashishb ashishb deleted the trevor/vm-testnet-app-and-logs branch September 24, 2019 01:30
@ashishb ashishb restored the trevor/vm-testnet-app-and-logs branch September 24, 2019 02:11
@ashishb ashishb reopened this Sep 24, 2019
Copy link
Contributor

@timmoreton timmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timmoreton timmoreton assigned tkporter and unassigned timmoreton and nambrot Oct 3, 2019
@tkporter tkporter merged commit f6eafb8 into master Oct 3, 2019
@tkporter tkporter deleted the trevor/vm-testnet-app-and-logs branch October 3, 2019 22:24
aaronmgdr added a commit that referenced this pull request Oct 4, 2019
* master:
  [Protocol] Fix network id for alfajores in truffle configs (#1211)
  When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group (#771)
  Upload static VM testnet nodes, add stackdriver logging (#750)
  Revert "Make packages depend on git vesrion (not npm)" (#1201)
  Make packages depend on git vesrion (not npm) (#1192)
  [contractkit] Document methods (#1195)
  [ck] consistent send tx object in kit (#1191)
  Move docker images to use node v10 (#1183)
  [ContractKit]Fill more fields before web3 signing (#1133)
  [codecov]Fix codecov errors (#1147)
  [Wallet] Add support for address pasting in send input field (#1180)
  Fix verification pool validation (#1176)
  Improve QR Code scan ability (#1036)
  Add CLI commands around identity metadata (#1167)
  [wallet]Run geth in an infura-like mode (#1108)

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users SBAT run the wallet app with a VM testnet
4 participants