Improve QR Code scan ability #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…celo-monorepo into rohit-dua/upgrade-qr-code-scan
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
=========================================
+ Coverage 66.06% 66.16% +0.1%
=========================================
Files 261 262 +1
Lines 7564 7610 +46
Branches 437 443 +6
=========================================
+ Hits 4997 5035 +38
- Misses 2471 2478 +7
- Partials 96 97 +1
Continue to review full report at Codecov.
|
jmrossy
reviewed
Sep 19, 2019
| @@ -129,6 +129,7 @@ android { | |||
| testBuildType System.getProperty('testBuildType', 'debug') | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
| resValue "string", "build_config_package", "org.celo.mobile" | |||
| missingDimensionStrategy 'react-native-camera', 'mlkit' | |||
There was a problem hiding this comment.
Can we get a rough estimate of how much this mlkit affects the apk size?
Here are the commands to build an apk, from the android folder:
./gradlew clean
./gradlew bundleReleaseJsAndAssets
./gradlew assembleRelease -x bundleReleaseJsAndAssets
| @@ -0,0 +1,117 @@ | |||
| import _QRCode from 'qrcode' | |||
There was a problem hiding this comment.
Please add tests for this file.
jmrossy
reviewed
Sep 25, 2019
…celo-monorepo into rohit-dua/upgrade-qr-code-scan
jmrossy
reviewed
Sep 30, 2019
| @@ -0,0 +1,21 @@ | |||
| import { genMatrix } from 'src/qrcode/QRGen' | |||
There was a problem hiding this comment.
No need for a new file here, merge it with the QRGen.test.tsx file and put it under a separate describe block.
Also, if a file doesn't contain jsx code, the filename should be just .ts
| } | ||
|
|
||
| onBardCodeDetected = (rawData: any) => { | ||
| if (rawData.type === BarcodeTypes.QR_CODE && this.state.qrSubmitted === false) { |
There was a problem hiding this comment.
Nit: Consider && !this.state.qrSubmitted
jmrossy
reviewed
Oct 2, 2019
packages/mobile/android/build.gradle
Outdated
| @@ -43,6 +43,15 @@ allprojects { | |||
| flatDir { | |||
| dirs celoClientDirectory | |||
| } | |||
| maven { | |||
| url "https://sdks.instabug.com/nexus/repository/instabug-cp" | |||
There was a problem hiding this comment.
This maven entry looks like a merge conflict, I removed this a few days ago
jmrossy
approved these changes
Oct 2, 2019
aaronmgdr
added a commit
that referenced
this pull request
Oct 4, 2019
* master: [Protocol] Fix network id for alfajores in truffle configs (#1211) When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group (#771) Upload static VM testnet nodes, add stackdriver logging (#750) Revert "Make packages depend on git vesrion (not npm)" (#1201) Make packages depend on git vesrion (not npm) (#1192) [contractkit] Document methods (#1195) [ck] consistent send tx object in kit (#1191) Move docker images to use node v10 (#1183) [ContractKit]Fill more fields before web3 signing (#1133) [codecov]Fix codecov errors (#1147) [Wallet] Add support for address pasting in send input field (#1180) Fix verification pool validation (#1176) Improve QR Code scan ability (#1036) Add CLI commands around identity metadata (#1167) [wallet]Run geth in an infura-like mode (#1108) # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QR scan library react-native-camera currently uses an old version 1.9.1. It is upgraded to 2.9.0. Also the function to scan QR codes is changed to the one that uses Google vision API.
The share QR code button downloads the QR code image as png. When viewed in the gallery it is viewed on a black background by default. The QR scanning is inefficient when the QR code is on a black background. Hence a white margin of 10px(each side) is added to the image
Tested
Scan Tested locally
Related issues