[ck] consistent send tx object in kit #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves send-tx logic inside kit * Use the same logic to send a simple transaction and a transaction object * Remove gasFeeRecipient (was not being used) * Use `Tx` to pass extra options, instead of a custom `TxOptions`
ashishb
reviewed
Oct 2, 2019
ashishb
reviewed
Oct 2, 2019
ashishb
approved these changes
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 261 261
Lines 7599 7599
Branches 508 440 -68
=======================================
Hits 5028 5028
- Misses 2474 2476 +2
+ Partials 97 95 -2
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Oct 4, 2019
* master: [Protocol] Fix network id for alfajores in truffle configs (#1211) When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group (#771) Upload static VM testnet nodes, add stackdriver logging (#750) Revert "Make packages depend on git vesrion (not npm)" (#1201) Make packages depend on git vesrion (not npm) (#1192) [contractkit] Document methods (#1195) [ck] consistent send tx object in kit (#1191) Move docker images to use node v10 (#1183) [ContractKit]Fill more fields before web3 signing (#1133) [codecov]Fix codecov errors (#1147) [Wallet] Add support for address pasting in send input field (#1180) Fix verification pool validation (#1176) Improve QR Code scan ability (#1036) Add CLI commands around identity metadata (#1167) [wallet]Run geth in an infura-like mode (#1108) # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
object
Txto pass extra options, instead of a customTxOptionsTested
yarn test