CLI relock fix #2464
Merged
CLI relock fix #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsmkl
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 280 280
Lines 7920 7920
Branches 1015 1015
=======================================
Hits 5903 5903
Misses 1903 1903
Partials 114 114
Continue to review full report at Codecov.
|
yerdua
reviewed
Jan 21, 2020
Comment on lines
+80
to
+84
| if (bn % EPOCH < 50) { | ||
| await mineBlocks(EPOCH + 20, web3) | ||
| } else { | ||
| await mineBlocks(EPOCH - 20, web3) | ||
| } |
There was a problem hiding this comment.
What's the rationale behind the +20 / -20?
There was a problem hiding this comment.
Well +20 is probably not useful, but -20 makes sure that the epoch won't change twice. Perhaps still need different handling for the case bn % EPOCH == 0.
yerdua
approved these changes
Jan 21, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 21, 2020
* master: (25 commits) Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) CLI relock fix (#2464) Update copyright year + inline button (#2468) Voting bot for stake off (#2327) Change order of profile info (#2454) [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457) Unfreeze rewards by default (#2452) Baklava and baklavastaging deploys (#2421) Fix coin colors (#2441) Make governance CLI more usable (#2428) Slashing params for stake off phase 2 (#2418) [Wallet] Rollback zeroSync toggle in case it was not successful (#2434) [Wallet] Cleanup unused StateProps references (#2439) Add unit tests and cli checks for validator hotfix interaction (#2340) Add proper Spanish translations (#2427) Catch exceptions during polling (#2432) Add unfreeze-contracts command to celotool (#2433) ... # Conflicts: # packages/web/src/brandkit/common/MobileMenu.test.tsx # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Jan 21, 2020
* master: Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) CLI relock fix (#2464) Update copyright year + inline button (#2468) Voting bot for stake off (#2327) Change order of profile info (#2454) [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457) Unfreeze rewards by default (#2452) # Conflicts: # packages/web/src/analytics/analytics.test.ts # packages/web/src/brandkit/common/MobileMenu.test.tsx # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Jan 22, 2020
* master: add celo.org/about#contributors id (#2488) [Wallet] Fix integration build firebase db url on Android (#2495) Fixes governance CLI bugs encountered while running election contract upgrade (#2482) Add validator:signed-blocks command and fix validator:status bug (#2456) Bump @celo/celocli version to 0.0.34 (#2420) Fix Logo + backers number change (#2453) Improve election efficiency by short circuiting (#2475) Page for Experience / BrandKit / Composition (#2462) Configure the time to wait for text messages (#2450) Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) CLI relock fix (#2464) Update copyright year + inline button (#2468) Voting bot for stake off (#2327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added a check to make sure that locked value is not zero.
Tested
Added unit test.
Other changes
Trying to remove some flakiness from governance unit tests.
Related issues
Backwards compatibility