Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @celo/celocli version to 0.0.34 #2420

Merged
merged 10 commits into from
Jan 22, 2020

Conversation

nategraf
Copy link
Contributor

Description

Following the publishing instructions in https://github.com/celo-org/celo-monorepo/tree/master/README-dev.md I am bumping the versions for @celo/utils, @celo/contractkit and @celo/celocli

I will publish:

  • @celo/celocli version 0.0.33
  • @celo/utils version 0.1.5
  • @celo/contractkit version 0.2.9

@@ -17,7 +17,7 @@
"deploy": "./deploy.sh"
},
"dependencies": {
"@celo/contractkit": "0.2.0",
"@celo/contractkit": "0.2.10-dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockchain api, notification service, and verification pool can only rely on published versions. A limitation of the AppEngine / Cloud Functions deployment process. Recommend just leaving their CK versions as is unless they need this upgrade. Or upgrade them to the latest published version (not -dev) but would be good to test them before merging :)

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #2420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2420   +/-   ##
======================================
  Coverage    73.6%   73.6%           
======================================
  Files         554     554           
  Lines       13667   13667           
  Branches     1413    1352   -61     
======================================
  Hits        10059   10059           
- Misses       3328    3330    +2     
+ Partials      280     278    -2
Flag Coverage Δ
#mobile 74.79% <ø> (ø) ⬆️
#web 71.95% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/web/src/logos/Logo.tsx 100% <ø> (ø) ⬆️
packages/web/src/about/Backers.tsx 94.44% <ø> (ø) ⬆️
packages/web/src/about/backers/backers.ts 100% <ø> (ø) ⬆️
packages/web/src/utils/abortableFetch.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a8a11...1990bb5. Read the comment docs.

@nategraf nategraf added the automerge Have PR merge automatically when checks pass label Jan 22, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 3203262 into master Jan 22, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the victor/bump-celocli-version branch January 22, 2020 03:26
aaronmgdr added a commit that referenced this pull request Jan 22, 2020
* master:
  Fixes governance CLI bugs encountered while running election contract upgrade (#2482)
  Add validator:signed-blocks command and fix validator:status bug (#2456)
  Bump @celo/celocli version to 0.0.34 (#2420)
  Fix Logo + backers number change (#2453)
  Improve election efficiency by short circuiting (#2475)
  Page for Experience / BrandKit / Composition (#2462)
  Configure the time to wait for text messages (#2450)

# Conflicts:
#	packages/web/package.json
aaronmgdr added a commit that referenced this pull request Jan 22, 2020
* master:
  add celo.org/about#contributors id (#2488)
  [Wallet] Fix integration build firebase db url on Android (#2495)
  Fixes governance CLI bugs encountered while running election contract upgrade (#2482)
  Add validator:signed-blocks command and fix validator:status bug (#2456)
  Bump @celo/celocli version to 0.0.34 (#2420)
  Fix Logo + backers number change (#2453)
  Improve election efficiency by short circuiting (#2475)
  Page for Experience / BrandKit / Composition (#2462)
  Configure the time to wait for text messages (#2450)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
aaronmgdr added a commit that referenced this pull request Jan 23, 2020
* master: (72 commits)
  [Wallet] Fix incorrect empty state on the gold tab (#2510)
  Added ingress resource for celostats DNS (#2480)
  Fix celotool testnet deploy (#2501)
  [Wallet] Navigate to wallet home after payment request (#2500)
  Require Consent for tracking globally (#2489)
  new academic papers + minor fix to web events (#2502)
  [Wallet] Fetch tobin tax for exchanges (#1492)
  add celo.org/about#contributors id (#2488)
  [Wallet] Fix integration build firebase db url on Android (#2495)
  Fixes governance CLI bugs encountered while running election contract upgrade (#2482)
  Add validator:signed-blocks command and fix validator:status bug (#2456)
  Bump @celo/celocli version to 0.0.34 (#2420)
  Fix Logo + backers number change (#2453)
  Improve election efficiency by short circuiting (#2475)
  Page for Experience / BrandKit / Composition (#2462)
  Configure the time to wait for text messages (#2450)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  ...

# Conflicts:
#	.circleci/config.yml
#	packages/web/src/brandkit/common/Page.tsx
#	packages/web/src/logos/LogoLightBg.tsx
#	packages/web/static/locales/en/brand.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants