Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baklava and baklavastaging deploys #2421

Merged
merged 13 commits into from
Jan 15, 2020
Merged

Baklava and baklavastaging deploys #2421

merged 13 commits into from
Jan 15, 2020

Conversation

tkporter
Copy link
Contributor

Description

Small changes involved with the baklava & baklavastaging deploys.

Tested

Deployed!

Other changes

Fixed an issue when uploading files to google cloud storage with / in the name

Related issues

n/a

Backwards compatibility

Yes

Copy link
Contributor

@timmoreton timmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #2421 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage   74.53%   74.46%   -0.07%     
==========================================
  Files         280      278       -2     
  Lines        7920     7786     -134     
  Branches      731      994     +263     
==========================================
- Hits         5903     5798     -105     
+ Misses       1903     1876      -27     
+ Partials      114      112       -2
Flag Coverage Δ
#mobile 74.46% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/utils/currencyExchange.ts 77.14% <0%> (-1.43%) ⬇️
packages/mobile/src/home/CeloDollarsOverview.tsx 88.46% <0%> (-1.2%) ⬇️
packages/mobile/src/utils/formatting.ts 89.79% <0%> (-1.12%) ⬇️
...le/src/escrow/ReclaimPaymentConfirmationScreen.tsx 81.42% <0%> (ø) ⬆️
...ages/mobile/src/escrow/EscrowedPaymentListItem.tsx 72% <0%> (ø) ⬆️
packages/mobile/src/exchange/actions.ts 100% <0%> (ø) ⬆️
packages/mobile/src/escrow/actions.ts 100% <0%> (ø) ⬆️
...es/mobile/src/escrow/EscrowedPaymentListScreen.tsx 100% <0%> (ø) ⬆️
packages/mobile/test/values.ts 100% <0%> (ø) ⬆️
packages/mobile/test/schemas.ts 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc7516...20027ac. Read the comment docs.

@timmoreton
Copy link
Contributor

you'll want to wait until the commit that fixes the unit tests in #2418 is merged

@timmoreton timmoreton added the automerge Have PR merge automatically when checks pass label Jan 15, 2020
@timmoreton timmoreton merged commit b36adb1 into master Jan 15, 2020
@timmoreton timmoreton deleted the release/baklava-phase-2 branch January 15, 2020 22:37
aaronmgdr added a commit that referenced this pull request Jan 21, 2020
* master: (25 commits)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
  Change order of profile info (#2454)
  [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457)
  Unfreeze rewards by default (#2452)
  Baklava and baklavastaging deploys (#2421)
  Fix coin colors  (#2441)
  Make governance CLI more usable (#2428)
  Slashing params for stake off phase 2 (#2418)
  [Wallet] Rollback zeroSync toggle in case it was not successful (#2434)
  [Wallet] Cleanup unused StateProps references (#2439)
  Add unit tests and cli checks for validator hotfix interaction (#2340)
  Add proper Spanish translations (#2427)
  Catch exceptions during polling (#2432)
  Add unfreeze-contracts command to celotool (#2433)
  ...

# Conflicts:
#	packages/web/src/brandkit/common/MobileMenu.test.tsx
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants