Quickload for Homepage on low connectivity #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n announcement of any number of characters and still display on an screens size
aaronmgdr
commented
Nov 14, 2019
| textAlign: 'center', | ||
| zIndex: 1, | ||
| }, | ||
| mask: { |
There was a problem hiding this comment.
this was unused code that was duplicated in TextAnimation
aaronmgdr
commented
Nov 14, 2019
| @@ -49,6 +49,7 @@ | |||
| "memoize-one": "^5.1.1", | |||
| "mobile-detect": "^1.4.2", | |||
| "net": "^1.0.2", | |||
| "network-speed": "^2.0.3", | |||
There was a problem hiding this comment.
less than a K
https://bundlephobia.com/[email protected]
* master: (56 commits) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) Remove integration sync test Minor attestation service fixes (#1680) [wallet] Fixed Native phone picker Use native API instead (#1669) Fix token addresses for notification service (#1674) Add golang to setup docs [wallet] Hide invite education copy after invite was redeemed (#1670) [Wallet] Add spinner, timer, and tip text to Verification input screen (#1656) [Wallet] Fix app deprecation check mechanism (#1358) Point end-to-end governance test back to master (#1665) Add EpochRewards smart contract to calculate epoch rewards and payments (#1558) Optimized Attestation view calls and removal of the reveal TX (#1578) Support claim signatures and support Keybase claims (#1575) [Wallet] Add timestamp to top banner messages (#1657) Export geth metrics on VM testnet (#1351) ... # Conflicts: # yarn.lock
* master: (120 commits) Update docker image and instructions (#2000) DOCS correct typos (#1965) Add a space on payment request (#1935) expose signer through getValidator (#1997) Fix validator election migration bug with sorted list insertion (#1998) Deploy an oracle cronjob (#1814) Set default env in attestation service docker image as production (#1999) Attestation Bot POC (#1851) Only allow external RPCs for tx nodes (#1994) Specify web deps properly (#1950) Fix error calculating fees on currencies with high exchange rate (#1937) Small pre-stake-off CLI cleanup (#1953) Migrations: different CLabs groups gets different votes (#1960) [Wallet] Fix broken translation (decline, pay) (#1968) [Wallet]: Add Payments You've Requested notifications group & screen (#1902) [Wallet] Fix iOS bundle script failing with our monorepo setup (#1958) [NotificationService] Change exchange rate stored format (number timestamp and pair) (#1945) [Wallet] Fix premature hiding of syncing banner and increase some timeouts (#1957) Avoid `liner: function not supported in this terminal` (#1955) Support more human readable log output (#1929) ...
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
=======================================
Coverage 74.77% 74.77%
=======================================
Files 280 280
Lines 7826 7826
Branches 690 690
=======================================
Hits 5852 5852
Misses 1858 1858
Partials 116 116
Continue to review full report at Codecov.
|
* master: (27 commits) Experience Brand Kit 1.0 (#1948) Adjust reference to the rewards app (#2065) [Wallet] Compatibility with exchange rate in string format (#2060) Fix Typo in CI config (#2056) Fix additional attestations instructions (#2057) Allow a specified address to disable/enable rewards distribution (#1828) Aaronmgdr/leaderboard patch (#2055) Move attestation service instructions to main page (#2051) Point To Updated Join Celo Video (#2052) Fix minor issue withe the ordering of instructions changes to docs related to discovery (#2025) [Docs] Fix typos in Running a Validator docs (#2045) Add node flag to celocli to set the target node for a single command (#2020) Fix broken links and spruce up CLI docs for accounts command (#2027) Prevent clipping of arrow component (#2036) Allocates an initial balance to the attestation bot (#2019) gold and dollar flags are required for faucet script (#1943) Clean seed words text area when returns from empty wallet view (#1904) Update validator script (#2026) Docs: PoS, metadata, gateway fee plus cleanup (#2022) ...
cmcewen
approved these changes
Dec 5, 2019
|
lets ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Current Homepage of Celo.org has a large video that is loaded and played inline this does not work well for much of celos target areas of use. This Changes the behavior to only load the video if we can determine that the network connection is good and the device memory is not terrible, otherwise it keeps the new still SVG graphic in place.
Tested
on Firefox and chrome so far. while a few chrome only APIs are used there are fallbacks which mean the experience will not be hampered
Other changes
This also fixes an issue with Blue Banner where it would cut off long text on mobile by dynamically getting the real height of the banner and setting the Header to be offset by that amount rather than by a constant amount.
Related issues
Backwards compatibility