-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export geth metrics on VM testnet #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoreton
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think 1 prom-to-sd per VM is fine. setting resource limits might help limit the cost and bin pack better?
looks like you need to do |
…orepo into trevor/vm-geth-metrics
👍 cool, just added resource limits. They're usually at around 1m CPU and 10 Mi memory but I gave them some leeway |
aaronmgdr
added a commit
that referenced
this pull request
Nov 14, 2019
* master: (56 commits) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) Remove integration sync test Minor attestation service fixes (#1680) [wallet] Fixed Native phone picker Use native API instead (#1669) Fix token addresses for notification service (#1674) Add golang to setup docs [wallet] Hide invite education copy after invite was redeemed (#1670) [Wallet] Add spinner, timer, and tip text to Verification input screen (#1656) [Wallet] Fix app deprecation check mechanism (#1358) Point end-to-end governance test back to master (#1665) Add EpochRewards smart contract to calculate epoch rewards and payments (#1558) Optimized Attestation view calls and removal of the reveal TX (#1578) Support claim signatures and support Keybase claims (#1575) [Wallet] Add timestamp to top banner messages (#1657) Export geth metrics on VM testnet (#1351) ... # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sends geth metrics from VM geth nodes to stackdriver. Geth metrics are exposed in prometheus format directly on the VM on port 9200, which can only be reached from inside the VPC network. On the kubernetes side, 1 exporter pod is created for each VM node that sends the exposed prometheus metrics to stackdriver. Unfortunately creating 1 pod each was the only way to make
pod_id
on the stackdriver side be unique for each VM node & behave similar to the existing setup with K8-s based testnets.Tested
Ran my own VM testnet, saw metrics in stackdriver. Made sure that the existing use of the
prometheus-to-sd
helm chart would behave the sameOther changes
Made sure the firewall rules only apply to the appropriate instances. Changed
prometheus-to-sd
helm chart to be a statefulset that can be used for geth metrics in addition to the kube metrics we use the chart for already.Related issues
Backwards compatibility
Yes