Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Add timestamp to top banner messages #1657

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Nov 11, 2019

Description

Add timestamp to top banner messages. This would allow to show the same message again if needed.

Tested

Ran on iPhone Simulator

Other changes

Disable RNInstallReferrer.getReferrer call for iOS.

Related issues

Backwards compatibility

Yes

This would allow to show the same message again if needed
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1657 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
+ Coverage   73.78%   73.78%   +<.01%     
==========================================
  Files         279      279              
  Lines        7605     7606       +1     
  Branches      949      657     -292     
==========================================
+ Hits         5611     5612       +1     
  Misses       1881     1881              
  Partials      113      113
Flag Coverage Δ
#mobile 73.78% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/alert/AlertBanner.tsx 93.75% <ø> (ø) ⬆️
packages/mobile/src/shared/BackupPrompt.tsx 90.47% <ø> (ø) ⬆️
packages/mobile/src/invite/utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba60964...5d7a458. Read the comment docs.

@i1skn i1skn merged commit 2b3eb0b into celo-org:master Nov 11, 2019
@i1skn i1skn deleted the fix-show-error branch November 11, 2019 19:16
aaronmgdr added a commit that referenced this pull request Nov 14, 2019
* master: (56 commits)
  Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585)
  [Wallet] Add more local currencies (#1698)
  Switch to correct cluster when fauceting (#1687)
  [Wallet] Use the country of the phone number for determining the default local currency (#1684)
  [Wallet] Limit QR code scanner to 1 code per second (#1676)
  Update Dark backgrounds text color (#1677)
  Remove integration sync test
  Minor attestation service fixes (#1680)
  [wallet] Fixed Native phone picker Use native API instead (#1669)
  Fix token addresses for notification service (#1674)
  Add golang to setup docs
  [wallet] Hide invite education copy after invite was redeemed (#1670)
  [Wallet] Add spinner, timer, and tip text to Verification input screen (#1656)
  [Wallet] Fix app deprecation check mechanism (#1358)
  Point end-to-end governance test back to master (#1665)
  Add EpochRewards smart contract to calculate epoch rewards and payments (#1558)
  Optimized Attestation view calls and removal of the reveal TX (#1578)
  Support claim signatures and support Keybase claims (#1575)
  [Wallet] Add timestamp to top banner messages (#1657)
  Export geth metrics on VM testnet (#1351)
  ...

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants