Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Add check for $ENVFILE to pre-dev script #1324

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Oct 14, 2019

No description provided.

@jmrossy jmrossy requested a review from martinvol October 14, 2019 10:50
@jmrossy jmrossy requested a review from cmcewen as a code owner October 14, 2019 10:50
@jmrossy jmrossy added the automerge Have PR merge automatically when checks pass label Oct 14, 2019
@jmrossy jmrossy changed the title [Wallet] Add check for .env.test to pre-dev script [Wallet] Add check for $ENVFILE to pre-dev script Oct 14, 2019
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files         264      264           
  Lines        7745     7745           
  Branches      513      513           
=======================================
  Hits         5144     5144           
  Misses       2500     2500           
  Partials      101      101
Flag Coverage Δ
#mobile 66.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a23e26...e3525b7. Read the comment docs.

Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ashishb ashishb merged commit 5fb6a6a into master Oct 14, 2019
@ashishb ashishb deleted the rossy/wa-predev-script branch October 14, 2019 12:49
aaronmgdr added a commit that referenced this pull request Oct 23, 2019
* master:
  Integration deploy, don't overwrite genesis block if upgrading testnet (#1315)
  Fix broken Discord link (#1317)
  [Wallet] Add check for $ENVFILE to pre-dev script (#1324)
  Add GRADLE_OPTS note to SETUP.md (#1311)
  Allow validators to specify an attestationKey with which they sign attestations (#1313)
  Add step to install typescript and other minor edits (#1256)
  [Wallet] Add script to build sdk for env before running yarn dev (#1312)
  [Wallet] Fix ListView deprecation warning (#1293)
  Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296)
  Add ability to generate addresses directly from env file in celotool (#1294)
aaronmgdr added a commit that referenced this pull request Oct 23, 2019
* master:
  Integration deploy, don't overwrite genesis block if upgrading testnet (#1315)
  Fix broken Discord link (#1317)
  [Wallet] Add check for $ENVFILE to pre-dev script (#1324)
  Add GRADLE_OPTS note to SETUP.md (#1311)
  Allow validators to specify an attestationKey with which they sign attestations (#1313)
  Add step to install typescript and other minor edits (#1256)
  [Wallet] Add script to build sdk for env before running yarn dev (#1312)
  [Wallet] Fix ListView deprecation warning (#1293)
  Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296)
  Add ability to generate addresses directly from env file in celotool (#1294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants