Add ability to generate addresses directly from env file in celotool #1294
Conversation
annakaz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 264 264
Lines 7745 7745
Branches 444 444
=======================================
Hits 5144 5144
Misses 2502 2502
Partials 99 99
Continue to review full report at Codecov.
|
annakaz
changed the title
| @@ -0,0 +1,23 @@ | |||
| /* tslint:disable no-console */ | |||
There was a problem hiding this comment.
Just renamed this file which used to be account-address.ts
There was a problem hiding this comment.
With this rename, we might have to hunt down other places in the codebase that currently calls this command, it might be easier to rename your "new" command
| @@ -0,0 +1,18 @@ | |||
| /* tslint:disable no-console */ | |||
There was a problem hiding this comment.
Wanted to keep this as a separate command, as the address returned from the "faucet" Account Type in account-address.ts is no longer what we're using
There was a problem hiding this comment.
Sgtm, though we are still using the faucet account type right? Just for the public facing faucet, not for the internal faucet?
There was a problem hiding this comment.
Yeah, on second thought I think this will lead to more confusion, so removing the command for now
* master: Integration deploy, don't overwrite genesis block if upgrading testnet (#1315) Fix broken Discord link (#1317) [Wallet] Add check for $ENVFILE to pre-dev script (#1324) Add GRADLE_OPTS note to SETUP.md (#1311) Allow validators to specify an attestationKey with which they sign attestations (#1313) Add step to install typescript and other minor edits (#1256) [Wallet] Add script to build sdk for env before running yarn dev (#1312) [Wallet] Fix ListView deprecation warning (#1293) Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296) Add ability to generate addresses directly from env file in celotool (#1294)
* master: Integration deploy, don't overwrite genesis block if upgrading testnet (#1315) Fix broken Discord link (#1317) [Wallet] Add check for $ENVFILE to pre-dev script (#1324) Add GRADLE_OPTS note to SETUP.md (#1311) Allow validators to specify an attestationKey with which they sign attestations (#1313) Add step to install typescript and other minor edits (#1256) [Wallet] Add script to build sdk for env before running yarn dev (#1312) [Wallet] Fix ListView deprecation warning (#1293) Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296) Add ability to generate addresses directly from env file in celotool (#1294)
Description
Add command to celotool to generate account addresses that require the mnemonic (ex: validator, load_testing, tx_node, bootnode and faucet) from an env file.
Previously, this required manually passing in private keys. This now just uses the mnemonic in the encrypted env file.
Tested
Confirmed that
celotooljs generate validator-address --celo-env alfajores --i 0 --a validatorgenerates the correct faucet address foralfajoresand forintegration.Confirmed that an address is returned for all account types listed above.
Related issues
Backwards compatibility
Yes
Note that if we start using a node other than validator 0 as the faucet account, we will have to update this