[Wallet] Fix ListView deprecation warning #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 264 264
Lines 7745 7745
Branches 513 444 -69
=======================================
Hits 5144 5144
- Misses 2500 2502 +2
+ Partials 101 99 -2
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Oct 23, 2019
* master: Integration deploy, don't overwrite genesis block if upgrading testnet (#1315) Fix broken Discord link (#1317) [Wallet] Add check for $ENVFILE to pre-dev script (#1324) Add GRADLE_OPTS note to SETUP.md (#1311) Allow validators to specify an attestationKey with which they sign attestations (#1313) Add step to install typescript and other minor edits (#1256) [Wallet] Add script to build sdk for env before running yarn dev (#1312) [Wallet] Fix ListView deprecation warning (#1293) Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296) Add ability to generate addresses directly from env file in celotool (#1294)
aaronmgdr
added a commit
that referenced
this pull request
Oct 23, 2019
* master: Integration deploy, don't overwrite genesis block if upgrading testnet (#1315) Fix broken Discord link (#1317) [Wallet] Add check for $ENVFILE to pre-dev script (#1324) Add GRADLE_OPTS note to SETUP.md (#1311) Allow validators to specify an attestationKey with which they sign attestations (#1313) Add step to install typescript and other minor edits (#1256) [Wallet] Add script to build sdk for env before running yarn dev (#1312) [Wallet] Fix ListView deprecation warning (#1293) Set IN_MEMORY_DISCOVERY_TABLE=true for integration (#1296) Add ability to generate addresses directly from env file in celotool (#1294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a new warning that shows up on the
JoinCelloscreen following the changes made for iOS (#1225).It’s caused by
react-native-autocomplete-inputwhich uses aListView.I think it was thrown too early previously to be shown and now that the screen is wrapped in
SafeAreaView, the timing is different and triggers it.I've upgraded to the latest stable version of
react-native-autocomplete-inputwhich now uses aFlatList.Tested
Updated tests. Ran the app -> no warnings displayed on the
JoinCelloscreen.Other changes
react-native-autocomplete-inputto@celo/react-componentssince it's used only theredeclare module 'react-native-autocomplete-input'@celo/react-componentsfromdevDependenciestodependenciesfor the mobile projectRelated issues
Backwards compatibility
Yes.