EM-1237: Why CareerBuilder Layout and Placeholders #123
Conversation
arelia
changed the base branch from
master
to
topic/EM-644-fractal-pattern-library--more-docs
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "employer-style-base", | |||
| "version": "2.2.18", | |||
| "version": "2.2.18-alpha.3", | |||
There was a problem hiding this comment.
@toastercup let's talk about how we want to do this. When should we use alpha vs beta?
| @@ -90,6 +90,21 @@ | |||
|
|
|||
| // Item Bar | |||
|
|
|||
| $_item-bar-breakpoint: 750px; | |||
There was a problem hiding this comment.
For the team's edification - we should come up with a rule for when to use _ as a prefix to signify something special in our Sass. What's your rule for deciding whether or not to use this?
There was a problem hiding this comment.
I mentioned in the PR description
I've started prefixing variables with underscore when they are specific to one thing, per https://github.com/airbnb/css#variables
There was a problem hiding this comment.
ooooooooooooooooooooooooooooooooooooooooooooo
There was a problem hiding this comment.
😃 😃 😃 😃 😃 😃 😃 😃 😃
Airbnb actually uses that when the variable is specific to the file. I tried that but there were still times when I needed the variable in both Style Base and Employer
…al-pattern-library--more-docs EM-644: Fractal Pattern Library Documentation
to adjust for the padding that the rest of the content lives within this fixes the buy box being 20px outside of the area that the rest of the content is in see https://trello.com/c/OzxNjQma/34-buy-box-is-out-of-alignment-with-content-area and https://cb-content-enablement.atlassian.net/browse/EM-1480
b/c flag needs to not quite be on the edge
…anels--full-bleed-image update text-image-panels--full-bleed-image mixin so that text stays within .container
after setting max width for headline text it was no longer centered, this fixes that
mobile safari was scaling up font size on one paragraph on new why cb page in about section this paragraph wasn't styled any differently from other paragraphs on the page. it was using .employer-scope styles Safari has a bug where media queries and rems don't work together: https://stackoverflow.com/questions/13237782/safari-doesnt-calculate-rem-units-correct-when-scaling-with-media-width-heigh and https://stackoverflow.com/questions/25960783/why-does-safari-calculate-rems-in-media-queries-differently-than-other-browsers Added this property to fix it: http://www.456bereastreet.com/archive/201011/beware_of_-webkit-text-size-adjustnone/ and https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust But only for Safari, I didn't see the issue on ios Chrome or Firefox
arelia
force-pushed
the
topic/EM-1237-why-cb
branch
from
3510aea to
9b9ce45
Compare
Purpose
container-edge-calc(buy box)item-bar__container(homepage stats)text-image-panels--full-bleed-image(small biz cta)quad-layout(small biz benefits)header--extra-largeheading--hero--xlmixin, which had been a draftJIRA
https://cb-content-enablement.atlassian.net/browse/EM-1237
Changes
Improvements and fixes, Changes to developer setup/environment, Architectural changes, Migrations or Steps to Take on Production, Side effects
Library changes
Feature Server
Employer: http://web.employer-1.development.c66.me/company/why-careerbuilder
Pattern Library: http://cb-talent-development.github.io/employer-style-base/index.html
How to Verify These Changes
Specific pages to visit
Steps to take
Relevant PRs/Dependencies
Additional Information