Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM-1237: Why CareerBuilder Layout and Placeholders #123

Merged
merged 36 commits into from
Aug 24, 2017
Merged

EM-1237: Why CareerBuilder Layout and Placeholders #123

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
cd0a47d
Merge pull request #122 from cb-talent-development/topic/EM-644-fract…
arelia Aug 23, 2017
d355442
style: add header--extra-large and adjust heading--hero--xl
arelia Aug 15, 2017
0cc5e6b
style: create quad-layout mixin
arelia Aug 16, 2017
07d0525
style: add layout_split mixin
arelia Aug 16, 2017
e712dcd
style: add text-image-panels mixins
arelia Aug 16, 2017
d96617b
bump: bump in progress version 2.2.18-alpha.0
arelia Aug 16, 2017
a491096
style: add container-edge-margin mixin
arelia Aug 17, 2017
c2441cf
style: update container-edge-margin with additon of 20px
arelia Aug 17, 2017
000da09
chore: add optional offset to container-edge-margin
arelia Aug 17, 2017
aae5171
chore (breakpoints): add comment re updating breakpoints
arelia Aug 21, 2017
e3ba7cf
refactor: refactor container-edge-margin to work for padding
arelia Aug 21, 2017
c10b59b
refactor: remove half-text-image and refactor text-image-panels
arelia Aug 21, 2017
7af3601
refactor: update text-image-panels--full-bleed-image
arelia Aug 21, 2017
2dc76b3
style: add item-bar__container mixin
arelia Aug 21, 2017
60f9270
bump: bump in progress style base 2.2.18-alpha.1
arelia Aug 21, 2017
50f0d27
refactor: allow header--extra-large mixin to take any gradient value
arelia Aug 21, 2017
4edf7b1
bump: bump in progress style base 2.2.18-alpha.2
arelia Aug 22, 2017
fd04da8
doc: document container_edge_calc mixin
arelia Aug 22, 2017
fb9a20d
doc: add quad and text-image layouts to pattern library
arelia Aug 22, 2017
311d104
doc: update selector and notes for text-image-panels--full-bleed-image
arelia Aug 22, 2017
7aeeaa9
chore: update .css output
arelia Aug 22, 2017
df7649f
bump: bump in progress version 2.2.18-alpha.3
arelia Aug 22, 2017
36ad9d1
chore: update where build output goes
arelia Aug 22, 2017
4a7f150
refactor (why-cb, small-biz): add container-edge-calc to text-image-p…
arelia Aug 22, 2017
f11943a
bump: bump in progress style base 2.2.18-alpha.4
arelia Aug 22, 2017
c146875
refactor: convert pxs to ems/rems
arelia Aug 22, 2017
66679f2
bump: bump in progress style base 2.2.18-alpha.5
arelia Aug 22, 2017
3651572
style (why-cb, small-biz): correct headline width on text-image-panel…
arelia Aug 22, 2017
e272613
bump: bump in progress style base 2.2.18-alpha.6
arelia Aug 22, 2017
25b6415
fix (why-cb, small biz): set margin auto on text-image-panels-content
arelia Aug 23, 2017
dfc9521
style: add line-height: normal to xl header text
arelia Aug 23, 2017
9b9ce45
fix (sitewide): set -webkit-text-size-adjust: 100% on .employer-scope
arelia Aug 23, 2017
716fa06
chore: add -layout-breakpoint--min breakpoint
arelia Aug 23, 2017
a9cff3e
style: update small-screen xl header styles
arelia Aug 23, 2017
2d80427
bump: bump in progress version 2.2.18-alpha.7
arelia Aug 23, 2017
c6f5963
bump: bump 2.2.19
arelia Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: add item-bar__container mixin
  • Loading branch information
@arelia
arelia committed Aug 23, 2017
commit 2dc76b32efd748bd702b61a6a8cdcf01748a8941
15 changes: 15 additions & 0 deletions sass/directives/02_base_components/boxes/_boxes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,21 @@

// Item Bar

$_item-bar-breakpoint: 750px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the team's edification - we should come up with a rule for when to use _ as a prefix to signify something special in our Sass. What's your rule for deciding whether or not to use this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned in the PR description

I've started prefixing variables with underscore when they are specific to one thing, per https://github.com/airbnb/css#variables

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooooooooooooooooooooooooooooooooooooooooooo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 😃 😃 😃 😃 😃 😃 😃 😃

Airbnb actually uses that when the variable is specific to the file. I tried that but there were still times when I needed the variable in both Style Base and Employer


@mixin item-bar__container {
border-top: $base-border;
border-bottom: $base-border;
background-color: $panel-primary;
height: 145px;
display: flex;
align-items: center;

@media only screen and (max-width: $_item-bar-breakpoint) {
height: auto;
}
}

@mixin item-bar__list($breakpoint: $small-screen-max) {
@include display(flex);
@include justify-content(center);
Expand Down